Remove the cargo check subcommand from Rust 1.15
#3465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `cargo check` subcommand from the `rust-1.15.0` branch of Cargo. The rationale is explained in rust-lang/rust#38666, but the tl;dr; is that it's relatively buggy and not ready to ride the trains to stable. This commit takes as little an invasive as approach as possible by simply removing the `cargo check` command and associated tests. The backend remains with support for `cargo check`, but we shouldn't be exercising it in practice.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
2 tasks
|
@bors r+ |
|
📌 Commit c9e7ec7 has been approved by |
|
⌛ Testing commit c9e7ec7 with merge 7b5bb38... |
|
💔 Test failed - status-appveyor |
|
@bors: retry
…On Wed, Dec 28, 2016 at 4:30 PM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang-libs/cargo/build/1.0.729>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3465 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95CdlxxYSm66BOcuEiYtKDPKgXS3eks5rMv8vgaJpZM4LXQCy>
.
|
bors
added a commit
that referenced
this pull request
Dec 29, 2016
Remove the `cargo check` subcommand from Rust 1.15 This commit removes the `cargo check` subcommand from the `rust-1.15.0` branch of Cargo. The rationale is explained in rust-lang/rust#38666, but the tl;dr; is that it's relatively buggy and not ready to ride the trains to stable. This commit takes as little an invasive as approach as possible by simply removing the `cargo check` command and associated tests. The backend remains with support for `cargo check`, but we shouldn't be exercising it in practice.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
cargo checksubcommand from therust-1.15.0branchof Cargo. The rationale is explained in rust-lang/rust#38666, but the tl;dr; is
that it's relatively buggy and not ready to ride the trains to stable. This
commit takes as little an invasive as approach as possible by simply removing
the
cargo checkcommand and associated tests. The backend remains with supportfor
cargo check, but we shouldn't be exercising it in practice.