use space, not dash, in cargo --version output
#3730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-lang#3604 inadvertently changed the output format of `cargo --version`: ``` froydnj@hawkeye:~/src/cargo.git$ ./target/x86_64-unknown-linux-gnu/release/cargo --version cargo-0.17.0-dev (ae4a4d8 2017-01-27) froydnj@hawkeye:~/src/cargo.git$ cargo --version cargo 0.16.0-nightly (6e0c18c 2017-01-27) ``` Note the dash between cargo and the version number in the newer version. Let's put the space back to not break things that might depend on the `--version` output.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ Thanks! |
|
📌 Commit 635aa46 has been approved by |
|
⌛ Testing commit 635aa46 with merge 9f03af6... |
|
💔 Test failed - status-travis |
|
@bors: retry
…On Fri, Feb 17, 2017 at 5:48 PM bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/cargo/builds/202810358>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3730 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95APyOdRu6BErkIJfRQW_NczOKp8jks5rdjG3gaJpZM4MEfnz>
.
|
bors
added a commit
that referenced
this pull request
Feb 18, 2017
use space, not dash, in `cargo --version` output #3604 inadvertently changed the output format of `cargo --version`: ``` froydnj@hawkeye:~/src/cargo.git$ ./target/x86_64-unknown-linux-gnu/release/cargo --version cargo-0.17.0-dev (ae4a4d8 2017-01-27) froydnj@hawkeye:~/src/cargo.git$ cargo --version cargo 0.16.0-nightly (6e0c18c 2017-01-27) ``` Note the dash between cargo and the version number in the newer version. Let's put the space back to not break things that might depend on the `--version` output.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3604 inadvertently changed the output format of
cargo --version:Note the dash between cargo and the version number in the newer version.
Let's put the space back to not break things that might depend on the
--versionoutput.