Always produce artifact messages #3752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
That's the minimal work needed for #3670 I think. |
|
Looks good to me! Could this perhaps also include a json key to indicate whether the artifact was just compiled or not? |
|
☔ The latest upstream changes (presumably #3733) made this pull request unmergeable. Please resolve the merge conflicts. |
matklad
force-pushed
the
always-artifacts
branch
from
eb3adc4 to
9f22fbf
Compare
matklad
force-pushed
the
always-artifacts
branch
from
9f22fbf to
7bfd7dc
Compare
Added a "fresh" key |
|
@bors: r+ |
|
📌 Commit 7bfd7dc has been approved by |
|
⌛ Testing commit 7bfd7dc with merge 338c7b7... |
|
💔 Test failed - status-appveyor |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Feb 27, 2017
Always produce artifact messages This changes `artifact` messages in several ways: * They are produced even for fresh builds * They used the path after hard linking (@jsgf talked about it in the end of #3319 (comment)) * Don't produce filenames if the compiler has not actually produced the binaries (`-Z-no-trans`).
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Feb 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
artifactmessages in several ways:They are produced even for fresh builds
They used the path after hard linking (@jsgf talked about it in the end of Emit more info on --message-format=json #3319 (comment))
Don't produce filenames if the compiler has not actually produced the binaries (
-Z-no-trans).