Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build date from version #3820

Merged
merged 2 commits into from
Mar 12, 2017
Merged

Conversation

alexcrichton
Copy link
Member

This was done by rustc awhile ago anyway and the rustc build system isn't
exporting it.

This was done by rustc awhile ago anyway and the rustc build system isn't
exporting it.
@alexcrichton
Copy link
Member Author

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 12, 2017

📌 Commit 7e6c83f has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Mar 12, 2017

⌛ Testing commit 7e6c83f with merge 2bb4fa4...

@rust-highfive
Copy link

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented Mar 12, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member Author

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 12, 2017

📌 Commit f7075d9 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Mar 12, 2017

⌛ Testing commit f7075d9 with merge 599a127...

@lambda-fairy
Copy link
Contributor

Does this fix #3819? Looks like it touches the same lines of code.

@alexcrichton
Copy link
Member Author

Yes this is the start to fixing that issues, not the end.

@bors
Copy link
Contributor

bors commented Mar 12, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 12, 2017

📌 Commit cac2216 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Mar 12, 2017

⌛ Testing commit cac2216 with merge d5e6f1d...

@bors
Copy link
Contributor

bors commented Mar 12, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 12, 2017

📌 Commit 0ec7c11 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Mar 12, 2017

⌛ Testing commit 0ec7c11 with merge 10cca2b...

@bors
Copy link
Contributor

bors commented Mar 12, 2017

💔 Test failed - status-travis

Just trying to get a PR to land...
@alexcrichton
Copy link
Member Author

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 12, 2017

📌 Commit 401153c has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Mar 12, 2017

⌛ Testing commit 401153c with merge 16d8706...

bors added a commit that referenced this pull request Mar 12, 2017
Remove build date from version

This was done by rustc awhile ago anyway and the rustc build system isn't
exporting it.
@bors
Copy link
Contributor

bors commented Mar 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 16d8706 to master...

@bors bors merged commit 401153c into rust-lang:master Mar 12, 2017
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 12, 2017
This commit updates Cargo with rust-lang/cargo#3820 which includes a fix for
rust-lang/cargo#3819. At the same time this also slightly tweaks how rustbuild
builds cargo to ensure that all the build information (including git info and
such) makes its way into the binary.

Closes rust-lang/cargo#3820
bors added a commit to rust-lang/rust that referenced this pull request Mar 12, 2017
Update Cargo to fix nightly channel

This commit updates Cargo with rust-lang/cargo#3820 which includes a fix for
rust-lang/cargo#3819. At the same time this also slightly tweaks how rustbuild
builds cargo to ensure that all the build information (including git info and
such) makes its way into the binary.

Closes rust-lang/cargo#3819
@alexcrichton alexcrichton deleted the remove-build-date branch March 13, 2017 16:18
@ehuss ehuss added this to the 1.17.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants