Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert template until after rfc #3878

Merged
merged 6 commits into from
Mar 31, 2017
Merged

Revert template until after rfc #3878

merged 6 commits into from
Mar 31, 2017

Conversation

ehiggs
Copy link
Contributor

@ehiggs ehiggs commented Mar 29, 2017

As discussed in #3860, templates was merged without going through the RFC process. @ssokolow has raised some useful comments which need to be settled before the template system can be put back in.

#3859 was another relevant issue.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton mentioned this pull request Mar 30, 2017
Closed
@alexcrichton
Copy link
Member

@bors: r+

Thanks @ehiggs for staying on top of this! If you need any help writing an RFC please just let me know, I'd be eager to see this in Cargo :)

@bors
Copy link
Contributor

bors commented Mar 30, 2017

📌 Commit b998130 has been approved by alexcrichton

@alexcrichton alexcrichton mentioned this pull request Mar 30, 2017
Closed
@alexcrichton
Copy link
Member

@ehiggs oh so some further steps we'll need to take on this are:

  • Send a PR to the rust-1.17.0 branch of this repo with these same contents
  • Send a PR to rust-lang/rust to update the cargo submodule on rust's master branch
  • Send a PR to rust-.ang/rust for the beta branch as well

I certainly don't mind doing these as well, but if you're interested in learning the process it's just a few PRs and I'd also be more than happy to r+!

@ehiggs
Copy link
Contributor Author

ehiggs commented Mar 30, 2017

Ok, I'll take a look at doing this.

@bors
Copy link
Contributor

bors commented Mar 30, 2017

⌛ Testing commit b998130 with merge ec67e38...

@bors
Copy link
Contributor

bors commented Mar 30, 2017

💔 Test failed - status-travis

@ehiggs
Copy link
Contributor Author

ehiggs commented Mar 30, 2017

homu job failed with error: component download failed for rust-std-mipsel-unknown-linux-gnu. Seems a transient failure.

@alexcrichton
Copy link
Member

alexcrichton commented Mar 30, 2017 via email

@bors
Copy link
Contributor

bors commented Mar 30, 2017

⌛ Testing commit b998130 with merge f4584ab...

@bors
Copy link
Contributor

bors commented Mar 30, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

alexcrichton commented Mar 31, 2017 via email

@bors
Copy link
Contributor

bors commented Mar 31, 2017

⌛ Testing commit b998130 with merge a07912a...

@bors
Copy link
Contributor

bors commented Mar 31, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Mar 31, 2017 via email

@bors
Copy link
Contributor

bors commented Mar 31, 2017

⌛ Testing commit b998130 with merge d3d3d3f...

@bors
Copy link
Contributor

bors commented Mar 31, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Mar 31, 2017 via email

@bors
Copy link
Contributor

bors commented Mar 31, 2017

⌛ Testing commit b998130 with merge f53fec0...

bors added a commit that referenced this pull request Mar 31, 2017
@bors
Auto merge of #3878 - ehiggs:revert-template-until-after-rfc, r=alexc…
f53fec0 
…richton

Revert template until after rfc

As discussed in #3860, templates was merged without going through the RFC process. @ssokolow has raised some useful comments which need to be settled before the template system can be put back in.

#3859 was another relevant issue.
@ehiggs
Copy link
Contributor Author

ehiggs commented Mar 31, 2017

Is this number of retries normal?

@alexcrichton
Copy link
Member

Not really, sometimes @bors just really doesn't like us :(

@bors
Copy link
Contributor

bors commented Mar 31, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing f53fec0 to master...

@bors bors merged commit b998130 into rust-lang:master Mar 31, 2017
This was referenced Mar 31, 2017
Merged
Closed
Merged
@ehiggs ehiggs mentioned this pull request Mar 31, 2017
Merged
bors added a commit that referenced this pull request Apr 1, 2017
@bors
Auto merge of #3888 - ehiggs:revert-template-until-after-rfc-1.17.0, …
2e31571 
…r=alexcrichton

Revert template until after rfc 1.17.0

As in #3878, remove templates until an RFC has passed.
@ehiggs
Copy link
Contributor Author

ehiggs commented Apr 10, 2017

Pre-rfc thread is here

@ebkalderon ebkalderon mentioned this pull request Jun 3, 2017
Closed
@WiSaGaN WiSaGaN mentioned this pull request Aug 11, 2017
Merged
@carols10cents carols10cents mentioned this pull request Jan 8, 2018
Closed
@mgattozzi mgattozzi mentioned this pull request Feb 15, 2018
Closed
@carols10cents carols10cents mentioned this pull request Mar 8, 2018
Open
@ehuss ehuss added this to the 1.18.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ehiggs @rust-highfive @alexcrichton @bors @ehuss