-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making tests less strict so they won't break on output changes #4055
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
f71d715
to
41e4904
Compare
Changes generally look good to me. I'll leave for @alexcrichton though since I'm not familiar with Cargo. |
@bors: r+ Thanks! |
📌 Commit 74f5694 has been approved by |
…chton Making tests less strict so they won't break on output changes Required for rust-lang/rust#41910 cc @Mark-Simulacrum cc @alexcrichton
💔 Test failed - status-travis |
@alexcrichton failed jod seems to have empty log. Can you restart it maybe? |
@bors: retry How odd! |
…chton Making tests less strict so they won't break on output changes Required for rust-lang/rust#41910 cc @Mark-Simulacrum cc @alexcrichton
☀️ Test successful - status-appveyor, status-travis |
Required for rust-lang/rust#41910
cc @Mark-Simulacrum
cc @alexcrichton