Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making tests less strict so they won't break on output changes #4055

Merged
merged 2 commits into from
May 17, 2017

Conversation

mersinvald
Copy link
Contributor

@mersinvald mersinvald commented May 16, 2017

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@mersinvald mersinvald force-pushed the less-strict-libtest-tests branch from f71d715 to 41e4904 Compare May 16, 2017 02:22
@Mark-Simulacrum
Copy link
Member

Changes generally look good to me. I'll leave for @alexcrichton though since I'm not familiar with Cargo.

@mersinvald mersinvald changed the title Making tests less strict so they don't break on output changes Making tests less strict so they won't break on output changes May 16, 2017
@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented May 16, 2017

📌 Commit 74f5694 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented May 16, 2017

⌛ Testing commit 74f5694 with merge 45de0e6...

bors added a commit that referenced this pull request May 16, 2017
…chton

Making tests less strict so they won't break on output changes

Required for rust-lang/rust#41910

cc @Mark-Simulacrum
cc @alexcrichton
@bors
Copy link
Contributor

bors commented May 16, 2017

💔 Test failed - status-travis

@mersinvald
Copy link
Contributor Author

@alexcrichton failed jod seems to have empty log. Can you restart it maybe?

@alexcrichton
Copy link
Member

@bors: retry

How odd!

@bors
Copy link
Contributor

bors commented May 16, 2017

⌛ Testing commit 74f5694 with merge a13266e...

bors added a commit that referenced this pull request May 16, 2017
…chton

Making tests less strict so they won't break on output changes

Required for rust-lang/rust#41910

cc @Mark-Simulacrum
cc @alexcrichton
@bors
Copy link
Contributor

bors commented May 17, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a13266e to master...

@bors bors merged commit 74f5694 into rust-lang:master May 17, 2017
@ehuss ehuss added this to the 1.19.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants