Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc/manifest] Add build-dependencies to Dependency sections list #4329

Merged
merged 1 commit into from
Jul 26, 2017

Conversation

behnam
Copy link
Contributor

@behnam behnam commented Jul 26, 2017

The [build-dependencies] section was missing from the Dependency
sections list, making it hard to find its existence and link to
specifying-dependencies page. This puts the section title in the list,
so a normal find works.

Background: #4309 (comment)

The `[build-dependencies]` section was missing from the Dependency
sections list, making it hard to find its existence and link to
`specifying-dependencies` page. This puts the section title in the list,
so a normal find works.

Background: rust-lang#4309 (comment)
@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@matklad
Copy link
Member

matklad commented Jul 26, 2017

@bors r+

Great catch, @behnam !

@bors
Copy link
Contributor

bors commented Jul 26, 2017

📌 Commit 19d3a6f has been approved by matklad

@bors
Copy link
Contributor

bors commented Jul 26, 2017

⌛ Testing commit 19d3a6f with merge 5c05eb8...

bors added a commit that referenced this pull request Jul 26, 2017
[doc/manifest] Add build-dependencies to Dependency sections list

The `[build-dependencies]` section was missing from the Dependency
sections list, making it hard to find its existence and link to
`specifying-dependencies` page. This puts the section title in the list,
so a normal find works.

Background: #4309 (comment)
@bors
Copy link
Contributor

bors commented Jul 26, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 5c05eb8 to master...

@bors bors merged commit 19d3a6f into rust-lang:master Jul 26, 2017
@behnam behnam deleted the dev branch August 8, 2017 03:19
@ehuss ehuss added this to the 1.21.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants