Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/reference/index: Remove "Now that you have an overview" paragraph #4922

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

wking
Copy link
Contributor

@wking wking commented Jan 8, 2018

This wording was originally from 58a1804 (#2688), which added it to the end of the guide (where telling readers what they know makes some sense). It was moved to a "Cargo in Depth" section with 01aa9e3 (#4453), where it makes a bit less sense. When that section became the reference index in 3f2d93e (#4455) the context assumed by the paragraph was completely missing.

This commit removes the paragraph, which doesn't reduce the usefulness of the reference index. And the removal avoids confusing readers who start with the reference docs and may now have the assumed overview.

This wording was originally from 58a1804 (At the end, point to docs
that might be interesting next, 2016-05-17, rust-lang#2688), which added it to
the end of the guide (where telling readers what they know makes some
sense).  It was moved to a "Cargo in Depth" section with 01aa9e3
([src/doc/book] Move a paragraph to cargo-in-depth.md, 2017-08-31,
rust-lang#4453), where it makes a bit less sense.  When that section became the
reference index in 3f2d93e ([doc/book] Create dir for book sections,
2017-08-31, rust-lang#4455) the context assumed by the paragraph was completely
missing.

This commit removes the paragraph, which doesn't reduce the usefulness
of the reference index.  And the removal avoids confusing readers who
start with the reference docs and may now have the assumed overview.
@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Jan 8, 2018

📌 Commit 75f5172 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jan 8, 2018

⌛ Testing commit 75f5172 with merge dd28cd3...

bors added a commit that referenced this pull request Jan 8, 2018
…lexcrichton

doc/reference/index: Remove "Now that you have an overview" paragraph

This wording was originally from 58a1804 (#2688), which added it to the end of the guide (where telling readers what they know makes some sense).  It was moved to a "Cargo in Depth" section with 01aa9e3 (#4453), where it makes a bit less sense.  When that section became the reference index in 3f2d93e (#4455) the context assumed by the paragraph was completely missing.

This commit removes the paragraph, which doesn't reduce the usefulness of the reference index.  And the removal avoids confusing readers who start with the reference docs and may now have the assumed overview.
@bors
Copy link
Contributor

bors commented Jan 8, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing dd28cd3 to master...

@bors bors merged commit 75f5172 into rust-lang:master Jan 8, 2018
@wking wking deleted the reference-wording-from-guide-trailer branch January 9, 2018 00:00
@ehuss ehuss added this to the 1.25.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants