Add a synthetic dependency on num-traits #5188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the rust-lang/rust integration is compiling Cargo twice on dist builds, once for Cargo and once for the RLS. This is due to a dependency of Cargo being recompiled with different features when used from the RLS or not. For now paper over this problem with a synthetic dependency to prevent Cargo from being compiled twice.
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ Hehe, I still hope that one day RLS will just call cargo metadata :) |
|
📌 Commit 841f20a has been approved by |
bors
added a commit
that referenced
this pull request
Mar 15, 2018
Add a synthetic dependency on num-traits Right now the rust-lang/rust integration is compiling Cargo twice on dist builds, once for Cargo and once for the RLS. This is due to a dependency of Cargo being recompiled with different features when used from the RLS or not. For now paper over this problem with a synthetic dependency to prevent Cargo from being compiled twice.
|
☀️ Test successful - status-appveyor, status-travis |
matklad
added a commit
to matklad/rust
that referenced
this pull request
Mar 16, 2018
This notably includes * rust-lang/cargo#5152 * rust-lang/cargo#5188 The first one switches cargo from docopt to clap ( we also update to the latest calp in this repository), the second one should help us to unify feature flags for Cargo itself and RLS, and build Cargo libray only once.
|
I strongly disagree that we should be doing things like this. Now that you're intentionally doing a workaround, we should instead reopen and resolve #4048. |
|
@ishitatsuyuki if you'd like please open a feature request and not a bug report |
|
@alexcrichton How does that differ? Also I think #4048 is in the format of a feature request. |
|
Ok, in that case mind opening a new issue anyway with fresh information? |
|
Done as #5210. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the rust-lang/rust integration is compiling Cargo twice on dist
builds, once for Cargo and once for the RLS. This is due to a dependency of
Cargo being recompiled with different features when used from the RLS or not.
For now paper over this problem with a synthetic dependency to prevent Cargo
from being compiled twice.