[beta] Copy --all-features request to all workspace members
#5567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an accidental regression introduced in rust-lang#5012 where the `--all-features` CLI flag was only propagated to the "main crate" as opposed to all workspace packages. This behavior has [already been deemed][pr] as "basically not what you want", but for now it's best to avoid the regression. Closes rust-lang#5518 [pr]: rust-lang#5353
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
|
@bors: r+ |
|
📌 Commit 3bb99cc has been approved by |
|
⌛ Testing commit 3bb99cc with merge 913715801a6ff6d794b7932a5fae212224e0163d... |
|
💔 Test failed - status-travis |
|
@bors: r+ |
|
📌 Commit 7eb5665 has been approved by |
bors
added a commit
that referenced
this pull request
May 25, 2018
[beta] Copy `--all-features` request to all workspace members Backport of #5556
|
☀️ Test successful - status-appveyor, status-travis |
ehuss
added a commit
to ehuss/rust
that referenced
this pull request
Jun 12, 2018
- rust-lang/cargo#5577 - revert rust-lang/cargo#5461 (Support crate renames in `cargo metadata`) - rust-lang/cargo#5567 - Copy `--all-features` request to all workspace members
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jun 12, 2018
[BETA] Update Cargo - rust-lang/cargo#5577 - revert rust-lang/cargo#5461 (Support crate renames in `cargo metadata`) - rust-lang/cargo#5567 - Copy `--all-features` request to all workspace members
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5556