Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow -p in uninstall to accommodate error messages. #5840

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jul 31, 2018

The ambiguous spec error tells you to use -p which wasn't available for
this command.

Fixes #5006

The ambiguous spec error tells you to use `-p` which wasn't available for
this command.

Fixes rust-lang#5006
@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@ehuss
Copy link
Contributor Author

ehuss commented Jul 31, 2018

I'm not sure if this is the best way to fix it, but I couldn't think of a better way. This follows the same strategy as #3149 for pkgid. Also not sure if it deserves a test, though it would be easy to add.

@alexcrichton
Copy link
Member

@bors: r+

Sounds reasonable to me!

@bors
Copy link
Contributor

bors commented Jul 31, 2018

📌 Commit 9d57d76 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 31, 2018

⌛ Testing commit 9d57d76 with merge 35c309e...

bors added a commit that referenced this pull request Jul 31, 2018
Allow `-p` in `uninstall` to accommodate error messages.

The ambiguous spec error tells you to use `-p` which wasn't available for
this command.

Fixes #5006
@bors
Copy link
Contributor

bors commented Aug 1, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 35c309e to master...

@bors bors merged commit 9d57d76 into rust-lang:master Aug 1, 2018
@ehuss ehuss added this to the 1.29.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unhelpful error message trying to uninstall ambiguous crate name
4 participants