Drop the [/] test output macro #5851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
dwijnand
commented
Aug 2, 2018
| @@ -1290,7 +1290,6 @@ fn substitute_macros(input: &str) -> String { | |||
| ("[SUMMARY]", " Summary"), | |||
| ("[FIXING]", " Fixing"), | |||
| ("[EXE]", if cfg!(windows) { ".exe" } else { "" }), | |||
| ("[/]", if cfg!(windows) { "\\" } else { "/" }), | |||
tests/testsuite/support/mod.rs
Outdated
| @@ -831,6 +831,8 @@ impl Execs { | |||
| // Let's not deal with \r\n vs \n on windows... | |||
| let actual = actual.replace("\r", ""); | |||
| let actual = actual.replace("\t", "<tab>"); | |||
| // or / vs \ | |||
| let actual = actual.replace("\\", "/"); | |||
dwijnand
commented
Aug 2, 2018
| // Let's not deal with / vs \ (windows...) | ||
| let expected = expected.replace("\\", "/"); | ||
| let mut actual: &str = &actual.replace("\\", "/"); | ||
| let expected = substitute_macros(&expected); |
|
@bors: r+ So much better! |
|
📌 Commit 5071b38 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 2, 2018
Drop the [/] test output macro Refs #5742
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Aug 19, 2018
Remove backslash management in 2 tool_paths tests With #5851 this is no longer necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #5742