Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup tests by using single string commands, split on whitespaces #5854

Merged
merged 4 commits into from
Aug 2, 2018
Merged

Cleanup tests by using single string commands, split on whitespaces #5854

merged 4 commits into from
Aug 2, 2018

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Aug 2, 2018

Refs #5742

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

My hero! 🗻

@bors
Copy link
Collaborator

bors commented Aug 2, 2018

📌 Commit 83bcc39197a8350aa88cb8a362e50763b9c6b2b1 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Aug 2, 2018

⌛ Testing commit 83bcc39197a8350aa88cb8a362e50763b9c6b2b1 with merge 238128f9e51233dc7e84c2e4ae06da31d7211ded...

@bors
Copy link
Collaborator

bors commented Aug 2, 2018

💔 Test failed - status-travis

@dwijnand
Copy link
Member Author

dwijnand commented Aug 2, 2018

Fixed up & squashed 3 typos, & separately fixed an outlier.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Aug 2, 2018

📌 Commit f88ff96 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Aug 2, 2018

⌛ Testing commit f88ff96 with merge 24c12546beb2ccf9543078f004448b32f27942ec...

@bors
Copy link
Collaborator

bors commented Aug 2, 2018

💥 Test timed out

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Collaborator

bors commented Aug 2, 2018

⌛ Testing commit f88ff96 with merge 5badfb1...

bors added a commit that referenced this pull request Aug 2, 2018
@bors
Auto merge of #5854 - dwijnand:args-split_whitespace, r=alexcrichton
5badfb1 
Cleanup tests by using single string commands, split on whitespaces

Refs #5742
@bors
Copy link
Collaborator

bors commented Aug 2, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 5badfb1 to master...

@bors bors merged commit f88ff96 into rust-lang:master Aug 2, 2018
@dwijnand dwijnand deleted the args-split_whitespace branch August 3, 2018 06:23
@dwijnand dwijnand mentioned this pull request Aug 18, 2018
Merged
bors added a commit that referenced this pull request Aug 18, 2018
@bors
Auto merge of #5907 - dwijnand:collapse-test-cmd-args, r=matklad
99a44cd 
Collapse ProcessBuilder::arg calls in tests

Refs #5742
More of #5854
bors added a commit that referenced this pull request Aug 19, 2018
@bors
Auto merge of #5907 - dwijnand:collapse-test-cmd-args, r=matklad
a06570c 
Collapse ProcessBuilder::arg calls in tests

Refs #5742
More of #5854
@ehuss ehuss added this to the 1.29.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
1.29.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dwijnand @rust-highfive @alexcrichton @bors @ehuss