-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make cargo install
ignore .cargo/config
#5874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hehe, nice - so simple :) LGTM
May want to add a small note in the documentation that it is ignored during install (such as here). |
r=me with passing tests, thanks @japaric! |
With this implementation I'm seeing that |
Not sure exactly where, but (in case it helps) |
I'm not sure a new |
ping @japaric, wanted to circle back to see if you've had a chance to work on this? |
Sorry, I've been occupied with other WG stuff; I'll revisit this and #5946 today. |
I simplified the implementation. re-r? @alexcrichton |
Some of the testing utilities have changed, so you'll have to adapt the test for that. (I can help if you get stuck, but it should be easy) |
f8e6f45
to
942e367
Compare
Rebased and updated / fixed the unit test. |
📌 Commit 942e367 has been approved by |
make `cargo install` ignore .cargo/config closes #5850 r? @alexcrichton
☀️ Test successful - status-appveyor, status-travis |
closes #5850
r? @alexcrichton