Add support for rustc's --error-format short #5879

dwijnand · 2018-08-09T17:58:07Z

Running a local build of this branch on some broken code shows this kind of output:

18:42:29 $ dcargo check --message-format=short --tests
    Checking bufstream v0.1.3
    Checking cargo v0.30.0 (file:///d/cargo)
tests/testsuite/config.rs:298:9: error[E0308]: mismatched types
tests/testsuite/config.rs:307:9: error[E0308]: mismatched types
tests/testsuite/config.rs:363:9: error[E0308]: mismatched types
tests/testsuite/config.rs:367:9: error[E0308]: mismatched types
tests/testsuite/config.rs:371:9: error[E0308]: mismatched types
tests/testsuite/config.rs:375:9: error[E0308]: mismatched types
tests/testsuite/config.rs:382:9: error[E0308]: mismatched types
tests/testsuite/config.rs:386:9: error[E0308]: mismatched types
tests/testsuite/config.rs:400:9: error[E0308]: mismatched types
tests/testsuite/config.rs:428:9: error[E0308]: mismatched types
tests/testsuite/config.rs:479:9: error[E0308]: mismatched types
tests/testsuite/config.rs:491:9: error[E0308]: mismatched types
tests/testsuite/config.rs:496:9: error[E0308]: mismatched types
tests/testsuite/config.rs:501:9: error[E0308]: mismatched types
tests/testsuite/config.rs:506:9: error[E0308]: mismatched types
tests/testsuite/config.rs:512:9: error[E0308]: mismatched types
tests/testsuite/config.rs:582:9: error[E0308]: mismatched types
tests/testsuite/config.rs:660:9: error[E0308]: mismatched types
tests/testsuite/config.rs:666:9: error[E0308]: mismatched types
tests/testsuite/config.rs:672:9: error[E0308]: mismatched types
tests/testsuite/config.rs:678:9: error[E0308]: mismatched types
error: aborting due to 21 previous errors
error: Could not compile `cargo`.
warning: build failed, waiting for other jobs to finish...
error: build failed

Rehash of @QuietMisdreavus' #4720 now that --short-message is stable (thanks for the ping @pickfire!).

Feedback welcome.

rust-highfive · 2018-08-09T17:58:18Z

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

dwijnand · 2018-08-09T22:16:45Z

Should I remove .json_messages() so we make sure to handle the different message formats? For instance see this change in a parallel PR:

https://github.com/rust-lang/cargo/pull/5878/files#diff-7f98585dbf9d30aa100c8318e2c77e79R608

alexcrichton · 2018-08-10T03:15:01Z

This looks good to me, thanks! And yeah I think it may be fine to test out how verbose a removal of .json_messages() looks like, if it's a pretty small diff I think it should be safe to remove

ehuss · 2018-08-10T04:15:03Z

src/cargo/core/compiler/mod.rs

@@ -745,8 +745,10 @@ fn build_base_args<'a, 'cfg>(
    add_path_args(bcx, unit, cmd);
    add_color(bcx, cmd);

-    if bcx.build_config.json_messages() {
-        cmd.arg("--error-format").arg("json");
+    match bcx.build_config.message_format {


When you rebase, I think it would be nice to pull this out into a separate function so that both the rustc and rustdoc calls could share the same code.

Running a local build of this branch on some broken code shows this kind of output: 18:42:29 $ dcargo check --message-format=short --tests Checking bufstream v0.1.3 Checking cargo v0.30.0 (file:///d/cargo) tests/testsuite/config.rs:298:9: error[E0308]: mismatched types tests/testsuite/config.rs:307:9: error[E0308]: mismatched types tests/testsuite/config.rs:363:9: error[E0308]: mismatched types tests/testsuite/config.rs:367:9: error[E0308]: mismatched types tests/testsuite/config.rs:371:9: error[E0308]: mismatched types tests/testsuite/config.rs:375:9: error[E0308]: mismatched types tests/testsuite/config.rs:382:9: error[E0308]: mismatched types tests/testsuite/config.rs:386:9: error[E0308]: mismatched types tests/testsuite/config.rs:400:9: error[E0308]: mismatched types tests/testsuite/config.rs:428:9: error[E0308]: mismatched types tests/testsuite/config.rs:479:9: error[E0308]: mismatched types tests/testsuite/config.rs:491:9: error[E0308]: mismatched types tests/testsuite/config.rs:496:9: error[E0308]: mismatched types tests/testsuite/config.rs:501:9: error[E0308]: mismatched types tests/testsuite/config.rs:506:9: error[E0308]: mismatched types tests/testsuite/config.rs:512:9: error[E0308]: mismatched types tests/testsuite/config.rs:582:9: error[E0308]: mismatched types tests/testsuite/config.rs:660:9: error[E0308]: mismatched types tests/testsuite/config.rs:666:9: error[E0308]: mismatched types tests/testsuite/config.rs:672:9: error[E0308]: mismatched types tests/testsuite/config.rs:678:9: error[E0308]: mismatched types error: aborting due to 21 previous errors error: Could not compile `cargo`. warning: build failed, waiting for other jobs to finish... error: build failed

dwijnand · 2018-08-10T07:35:49Z

@ehuss done

@alexcrichton I tested it and didn't like the look of it (I could see someone, like myself, cleaning it up after). I think this is just the reality of changing algebraic data types combined with parallel development. But let me know if you have any further thoughts!

alexcrichton · 2018-08-10T14:28:15Z

@bors: r+

bors · 2018-08-10T14:28:16Z

📌 Commit 2c704d8 has been approved by alexcrichton

bors · 2018-08-10T14:28:24Z

⌛ Testing commit 2c704d8 with merge ef1b6453ba0c27337ae35f82c585a3f9b8da5dc2...

bors · 2018-08-10T15:05:02Z

💔 Test failed - status-travis

alexcrichton · 2018-08-10T15:07:33Z

@bors: retry

bors · 2018-08-10T15:07:40Z

⌛ Testing commit 2c704d8 with merge 03c55c688d8d1dc7ae7fb0672fc51b39cdd4ea4f...

bors · 2018-08-10T16:00:20Z

💔 Test failed - status-travis

dwijnand · 2018-08-10T16:12:46Z

Travis CI failed even worst this time round.. 😕

error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-nightly.toml.sha256' to '/home/travis/.rustup/tmp/o4tx0_y55x5dl6yn_file'
info: caused by: error during download
info: caused by: [28] Timeout was reached (Connection timed out after 30000 milliseconds)

dwijnand · 2018-08-12T07:07:14Z

This could use a @bors: retry when someone gets a second.

ehuss · 2018-08-12T15:00:53Z

@bors retry

bors · 2018-08-12T15:01:00Z

⌛ Testing commit 2c704d8 with merge 972ccba...

@QuietMisdreavus

Add support for rustc's --error-format short Running a local build of this branch on some broken code shows this kind of output: 18:42:29 $ dcargo check --message-format=short --tests Checking bufstream v0.1.3 Checking cargo v0.30.0 (file:///d/cargo) tests/testsuite/config.rs:298:9: error[E0308]: mismatched types tests/testsuite/config.rs:307:9: error[E0308]: mismatched types tests/testsuite/config.rs:363:9: error[E0308]: mismatched types tests/testsuite/config.rs:367:9: error[E0308]: mismatched types tests/testsuite/config.rs:371:9: error[E0308]: mismatched types tests/testsuite/config.rs:375:9: error[E0308]: mismatched types tests/testsuite/config.rs:382:9: error[E0308]: mismatched types tests/testsuite/config.rs:386:9: error[E0308]: mismatched types tests/testsuite/config.rs:400:9: error[E0308]: mismatched types tests/testsuite/config.rs:428:9: error[E0308]: mismatched types tests/testsuite/config.rs:479:9: error[E0308]: mismatched types tests/testsuite/config.rs:491:9: error[E0308]: mismatched types tests/testsuite/config.rs:496:9: error[E0308]: mismatched types tests/testsuite/config.rs:501:9: error[E0308]: mismatched types tests/testsuite/config.rs:506:9: error[E0308]: mismatched types tests/testsuite/config.rs:512:9: error[E0308]: mismatched types tests/testsuite/config.rs:582:9: error[E0308]: mismatched types tests/testsuite/config.rs:660:9: error[E0308]: mismatched types tests/testsuite/config.rs:666:9: error[E0308]: mismatched types tests/testsuite/config.rs:672:9: error[E0308]: mismatched types tests/testsuite/config.rs:678:9: error[E0308]: mismatched types error: aborting due to 21 previous errors error: Could not compile `cargo`. warning: build failed, waiting for other jobs to finish... error: build failed Rehash of @QuietMisdreavus' #4720 now that `--short-message` is stable (thanks for the ping @pickfire!). Feedback welcome.

bors · 2018-08-12T16:04:01Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 972ccba to master...

Update cargo - Update transitioning url (rust-lang/cargo#5889) - Resolve some clippy lint warnings (rust-lang/cargo#5884) - Don't kill child processes on normal exit on Windows (rust-lang/cargo#5887) - fix a bunch of clippy warnings (rust-lang/cargo#5876) - Add support for rustc's --error-format short (rust-lang/cargo#5879) - Support JSON with rustdoc. (rust-lang/cargo#5878) - Fix rustfmt instructions in CONTRIBUTING.md (rust-lang/cargo#5880) - Allow `cargo run` in workspaces. (rust-lang/cargo#5877) - Change target filters in workspaces. (rust-lang/cargo#5873) - Improve verbose console and log for finding git repo in package check (rust-lang/cargo#5858) - Meta rename (rust-lang/cargo#5871) - fetch: skip target tests when cross_compile is disabled (rust-lang/cargo#5870) - Fully capture rustc and rustdoc output when -Zcompile-progress is passed (rust-lang/cargo#5862) - Fix test --example docs. (rust-lang/cargo#5867) - Add a feature to build a vendored OpenSSL (rust-lang/cargo#5865)

rust-highfive assigned alexcrichton Aug 9, 2018

ehuss reviewed Aug 10, 2018

View reviewed changes

dwijnand added 2 commits August 10, 2018 08:22

Add a test for "cargo check --message-format=short"

a14f7fe

dwijnand force-pushed the short-errors branch from b55adcf to 9a1c183 Compare August 10, 2018 07:33

dwijnand added 2 commits August 10, 2018 08:49

Extract & reuse add_error_format for rustdoc too

99ed7ea

Add a test for "cargo doc --message-format=short"

2c704d8

dwijnand force-pushed the short-errors branch from 9a1c183 to 2c704d8 Compare August 10, 2018 07:49

dwijnand mentioned this pull request Aug 12, 2018

https://static.rust-lang.org/dist/ is flakey rust-lang/infra-team#16

Closed

bors merged commit 2c704d8 into rust-lang:master Aug 12, 2018

dwijnand deleted the short-errors branch August 12, 2018 16:05

ehuss mentioned this pull request Aug 14, 2018

Update cargo rust-lang/rust#53367

Merged

sanmai-NL mentioned this pull request Sep 6, 2018

add support for rustc's --error-format short #4720

Closed

ehuss added this to the 1.30.0 milestone Feb 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for rustc's --error-format short #5879

Add support for rustc's --error-format short #5879

dwijnand commented Aug 9, 2018

rust-highfive commented Aug 9, 2018

dwijnand commented Aug 9, 2018

alexcrichton commented Aug 10, 2018

ehuss Aug 10, 2018

dwijnand commented Aug 10, 2018

alexcrichton commented Aug 10, 2018

bors commented Aug 10, 2018

bors commented Aug 10, 2018

bors commented Aug 10, 2018

alexcrichton commented Aug 10, 2018

bors commented Aug 10, 2018

bors commented Aug 10, 2018

dwijnand commented Aug 10, 2018

dwijnand commented Aug 12, 2018

ehuss commented Aug 12, 2018

bors commented Aug 12, 2018

bors commented Aug 12, 2018

Add support for rustc's --error-format short #5879

Add support for rustc's --error-format short #5879

Conversation

dwijnand commented Aug 9, 2018

rust-highfive commented Aug 9, 2018

dwijnand commented Aug 9, 2018

alexcrichton commented Aug 10, 2018

ehuss Aug 10, 2018

Choose a reason for hiding this comment

dwijnand commented Aug 10, 2018

alexcrichton commented Aug 10, 2018

bors commented Aug 10, 2018

bors commented Aug 10, 2018

bors commented Aug 10, 2018

alexcrichton commented Aug 10, 2018

bors commented Aug 10, 2018

bors commented Aug 10, 2018

dwijnand commented Aug 10, 2018

dwijnand commented Aug 12, 2018

ehuss commented Aug 12, 2018

bors commented Aug 12, 2018

bors commented Aug 12, 2018