-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force cargo fix
to rebuild
#5944
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Ah yeah sure! I believe the pathological behavior can be seen by adding a dependency and I believe both invocations (in the test) will recompile the dependency, but only the requested crate (the one we're fixing) should be recompiled |
Thanks @alexcrichton I was able to come up with a test. It fails with this PR because it aggressively rebuilds and fails without this PR because it doesn't rebuild anything. 😄 Now on how to fix the problem.. |
Oh interesting, looks like CI passed? I personally prefer to use |
Gives more confidence.
Yep, I think this is fixed/done now! Good shout on using |
My friend |
@bors: r+ Clever! |
📌 Commit 7a42790 has been approved by |
Force `cargo fix` to rebuild Fixes #5736 This is a resubmit of @killercup's #5750, rebased on current master. @alexcrichton From browsing the code I feel like `-p` would still restrict the packages to rebuild, despite the rebuild flag added. But I might be misreading or not-fully-reading the code. Could you give me some mentoring instructions for the test cases you're concerned with?
☀️ Test successful - status-appveyor, status-travis |
Fixes #5736
This is a resubmit of @killercup's #5750, rebased on current master.
@alexcrichton From browsing the code I feel like
-p
would still restrict the packages to rebuild, despite the rebuild flag added. But I might be misreading or not-fully-reading the code. Could you give me some mentoring instructions for the test cases you're concerned with?