Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error code check in doc test #6027

Merged
merged 3 commits into from
Sep 15, 2018
Merged

Remove error code check in doc test #6027

merged 3 commits into from
Sep 15, 2018

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 14, 2018

📌 Commit de3c4cb5dba53ce28b31194e76237147475a230a has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Sep 14, 2018

⌛ Testing commit de3c4cb5dba53ce28b31194e76237147475a230a with merge 0aca6437ee5b61cf27c2056dc0bf047d1dd945e4...

@ehuss
Copy link
Contributor

ehuss commented Sep 14, 2018

This isn't going to pass because the test harness asserts that cargo returns 0 by default. There currently isn't a way to ignore the return code, though that can be easily added.

@GuillaumeGomez
Copy link
Member Author

Is it a check performed in cargo or in rustc? (if in rustc, I'll send the PR there which will give a nice cascade of PRs haha).

@ehuss
Copy link
Contributor

ehuss commented Sep 14, 2018

The check is in the testsuite code. The default is set here. I think it would be reasonable to add another method next to with_status that sets expect_exit_code to None.

@GuillaumeGomez
Copy link
Member Author

Agreed. Adding it to this PR as well.

@dwijnand
Copy link
Member

dwijnand commented Sep 14, 2018 •
edited
Loading

Maybe we can revert the test changes in b1d6a7e then ;-)

Edit: I mean in the future. Not (necessarily) in this PR.

@GuillaumeGomez
Copy link
Member Author

Euh... Ok! New commit incoming!

@GuillaumeGomez
Copy link
Member Author

@dwijnand: Done as well. Anything else? 😆

@dwijnand
Copy link
Member

Thank you! 🙇 Sorry for the misunderstanding.

@GuillaumeGomez
Copy link
Member Author

Cool! Then let's hope it'll pass tests now. :)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 14, 2018

📌 Commit 2fc6b3e has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Sep 14, 2018

⌛ Testing commit 2fc6b3e with merge 509bf99...

bors added a commit that referenced this pull request Sep 14, 2018
@bors
Auto merge of #6027 - GuillaumeGomez:remove-error-code-check, r=alexc…
509bf99 
…richton

Remove error code check in doc test

Needed by rust-lang/rust#53933

cc @alexcrichton
@bors
Copy link
Contributor

bors commented Sep 15, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 509bf99 to master...

@bors bors merged commit 2fc6b3e into rust-lang:master Sep 15, 2018
@GuillaumeGomez GuillaumeGomez deleted the remove-error-code-check branch September 15, 2018 09:18
@ehuss ehuss mentioned this pull request Oct 24, 2018
Merged
bors added a commit that referenced this pull request Oct 24, 2018
@bors
Auto merge of #6216 - ehuss:destabilize-edition, r=Mark-Simulacrum
2ee151f 
[BETA] Partially destabilize edition.

Removes edition from `cargo new`, and documentation.

Also includes (parts of) #6176 and #6027 to get the beta branch to pass tests on CI.
@ehuss ehuss added this to the 1.31.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matklad matklad

Labels
None yet
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
7 participants
@GuillaumeGomez @rust-highfive @alexcrichton @bors @ehuss @dwijnand @matklad