Never use templates when managing git repos #6252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me. @bors: r+ |
|
📌 Commit a2b0611b2c40f4f8f6967ce9d1fdcd5120c05c06 has been approved by |
ehuss
reviewed
Nov 2, 2018
ehuss
reviewed
Nov 2, 2018
tests/testsuite/git.rs
Outdated
| &format!(r#" | ||
| [init] | ||
| templatedir = {} | ||
| "#, git_project2.url().to_file_path().unwrap().display()).as_bytes(), |
There was a problem hiding this comment.
Suggested change
| "#, git_project2.url().to_file_path().unwrap().display()).as_bytes(), | |
| "#, | |
| git_project2 | |
| .url() | |
| .to_file_path() | |
| .unwrap() | |
| .display() | |
| .to_string() | |
| .replace("\\", "/") | |
| ) | |
| .as_bytes(), |
|
I think I broke/confused github trying the new suggestion feature. Anyways, I was trying to say, the code needs to be changed to: For "C:/path/to/thing" for gitconfig style paths (double quotes and forward slashes). |
|
⌛ Testing commit a2b0611b2c40f4f8f6967ce9d1fdcd5120c05c06 with merge 8e6b81c41c088d3bca9a6a2ba59ade2c815aaa4f... |
|
💔 Test failed - status-appveyor |
This commit disables usage of git templates whenever Cargo manages repositories in its internal git database. Templates don't want to be used at all in these situations and have been known to cause usability bugs. Closes rust-lang#6240
alexcrichton
force-pushed
the
clone-and-templtes
branch
from
a2b0611 to
2a4cdc6
Compare
|
@bors: r=dwijnand |
|
📌 Commit 2a4cdc6 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 2, 2018
Never use templates when managing git repos This commit disables usage of git templates whenever Cargo manages repositories in its internal git database. Templates don't want to be used at all in these situations and have been known to cause usability bugs. Closes #6240
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disables usage of git templates whenever Cargo manages
repositories in its internal git database. Templates don't want to be
used at all in these situations and have been known to cause usability
bugs.
Closes #6240