Show error on JSON parse error and nonzero exit. #6290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors: r+ |
|
📌 Commit 98953277462bcec3d422cd8f5732dc0603065025 has been approved by |
|
☔ The latest upstream changes (presumably #6289) made this pull request unmergeable. Please resolve the merge conflicts. |
ehuss
force-pushed
the
json-parse-error
branch
from
9895327
to
3f0c788
Compare
|
@bors r=alexcrichton |
|
📌 Commit 3f0c788 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 9, 2018
Show error on JSON parse error and nonzero exit. If JSON parsing failed, and rustc exits nonzero, the error was lost. This would have made it easier to diagnose #5992.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If JSON parsing failed, and rustc exits nonzero, the error was lost.
This would have made it easier to diagnose #5992.