HTTPS all the things #6614

claudijd · 2019-01-30T20:36:08Z

Noticed that we still have a bunch of HTTP links, which could present mild MiTM risks that we can totally remove.

One short coming of this was:

cargo/src/etc/_cargo:13 "http://zsh.sourceforge.net/Doc/Release/Completion-System.html#Completion-Functions" of which does not have an HTTPS equivalent yet.

rust-highfive · 2019-01-30T20:36:18Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

pietroalbini · 2019-01-30T20:37:37Z

r? @alexcrichton

src/cargo/ops/common_for_install_and_uninstall.rs

alexcrichton · 2019-01-30T21:07:28Z

@bors: r+

bors · 2019-01-30T21:07:30Z

📌 Commit 1584bb4 has been approved by alexcrichton

bors · 2019-01-30T21:07:38Z

⌛ Testing commit 1584bb4 with merge b98b7c00472ac5b1ce272dd1c3a009592c234d07...

dwijnand

Some fixups 🙂

src/cargo/ops/cargo_package.rs

src/cargo/ops/registry.rs

src/bin/cargo/commands/pkgid.rs

dwijnand · 2019-01-30T21:12:06Z

I can follow-up.

claudijd · 2019-01-30T21:17:30Z

@dwijnand fixed

dwijnand · 2019-01-30T21:27:39Z

@claudijd thanks!

@bors r=alexcrichton 6d9f3a6

bors · 2019-01-30T21:27:47Z

⌛ Testing commit 6d9f3a6 with merge a2b6c20981274d3507a520b2535bb4f866833d60...

bors · 2019-01-30T22:00:48Z

💔 Test failed - checks-travis

tests/testsuite/build_auth.rs

alexcrichton · 2019-01-31T19:39:02Z

@bors: r+

bors · 2019-01-31T19:39:03Z

📌 Commit ee20f73 has been approved by alexcrichton

bors · 2019-01-31T19:39:14Z

⌛ Testing commit ee20f73 with merge 55c3bd3fb4a2b7490df7d9f93e2d3202ffb61341...

dwijnand · 2019-02-06T20:45:09Z

@bors retry

dwijnand · 2019-02-06T20:45:32Z

@bors r+

bors · 2019-02-06T20:45:33Z

📌 Commit a9480ed has been approved by dwijnand

bors · 2019-02-06T20:45:42Z

⌛ Testing commit a9480ed with merge 770dd2f...

HTTPS all the things Noticed that we still have a bunch of HTTP links, which could present mild MiTM risks that we can totally remove. One short coming of this was: cargo/src/etc/_cargo:13 "http://zsh.sourceforge.net/Doc/Release/Completion-System.html#Completion-Functions" of which does not have an HTTPS equivalent yet.

bors · 2019-02-06T21:10:03Z

💔 Test failed - checks-travis

bors · 2019-02-12T20:38:03Z

☔ The latest upstream changes (presumably #6654) made this pull request unmergeable. Please resolve the merge conflicts.

ehuss

@claudijd do you think you'd be able to rebase and fix the broken tests?

ehuss · 2019-02-14T01:21:41Z

tests/testsuite/build_auth.rs

@@ -126,11 +126,11 @@ fn http_auth_offered() {
        .with_status(101)
        .with_stderr_contains(&format!(
            "\
-[UPDATING] git repository `http://{addr}/foo/bar`


I don't think this test should be changed.

ehuss · 2019-02-14T01:22:27Z

tests/testsuite/build_auth.rs

@@ -171,7 +171,7 @@ fn https_something_happens() {
            authors = []

            [dependencies.bar]
-            git = "https://127.0.0.1:{}/foo/bar"
+            git = "http://127.0.0.1:{}/foo/bar"


This test shouldn't be modified, either.

ehuss · 2019-02-27T22:21:12Z

Thanks!

@bors r+

bors · 2019-02-27T22:21:13Z

📌 Commit 7185e98 has been approved by ehuss

bors · 2019-02-27T22:21:22Z

⌛ Testing commit 7185e98 with merge 131823a...

HTTPS all the things Noticed that we still have a bunch of HTTP links, which could present mild MiTM risks that we can totally remove. One short coming of this was: cargo/src/etc/_cargo:13 "http://zsh.sourceforge.net/Doc/Release/Completion-System.html#Completion-Functions" of which does not have an HTTPS equivalent yet.

bors · 2019-02-27T22:49:51Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: ehuss
Pushing 131823a to master...

@Xanewok

Update cargo, rls ## cargo 6 commits in 5c6aa46e6f28661270979696e7b4c2f0dff8628f..716b02cb4c7b75ce435eb06defa25bc2d725909c 2019-02-22 19:32:35 +0000 to 2019-03-02 14:23:51 +0000 - Some test/bench-related tweaks (rust-lang/cargo#6707) - Fix links to the permanent home of the edition guide. (rust-lang/cargo#6703) - HTTPS all the things (rust-lang/cargo#6614) - Cargo test quicker by not building untested examples when filtered (rust-lang/cargo#6683) - Link from ARCHITECTURE.md to docs.rs and github (rust-lang/cargo#6695) - Update how to install rustfmt (rust-lang/cargo#6696) ## rls 9 commits in 0d6f53e1a4adbaf7d83cdc0cb54720203fcb522e..6a1b5a9cfda2ae19372e0613e76ebefba36edcf5 2019-02-14 07:52:15 +0000 to 2019-03-04 20:24:45 +0000 - Update cargo and clippy. (rust-lang/rls#1388) - catch up rust-lang/rust PR#58321 (rust-lang/rls#1384) - Apply Clippy fixes (rust-lang/rls#1327) - Various cosmetic improvements (rust-lang/rls#1326) - Make test `RlsHandle` transport-agnostic (rust-lang/rls#1317) - Translate remaining tests (rust-lang/rls#1320) - Remove unnecessary #![feature]s (rust-lang/rls#1323) - Update Clippy (rust-lang/rls#1319) - Update Clippy (rust-lang/rls#1315) cc @Xanewok

@Xanewok

Update cargo, rls, books ## cargo 10 commits in 5c6aa46e6f28661270979696e7b4c2f0dff8628f..95b45eca19ac785263fed98ecefe540bb47337ac 2019-02-22 19:32:35 +0000 to 2019-03-06 19:24:30 +0000 - Relax some rustdoc tests. (rust-lang/cargo#6721) - Include build script execution in the fingerprint. (rust-lang/cargo#6720) - part of the infrastructure for public & private dependencies in the resolver (rust-lang/cargo#6653) - Bump to 0.36.0 (rust-lang/cargo#6718) - Some test/bench-related tweaks (rust-lang/cargo#6707) - Fix links to the permanent home of the edition guide. (rust-lang/cargo#6703) - HTTPS all the things (rust-lang/cargo#6614) - Cargo test quicker by not building untested examples when filtered (rust-lang/cargo#6683) - Link from ARCHITECTURE.md to docs.rs and github (rust-lang/cargo#6695) - Update how to install rustfmt (rust-lang/cargo#6696) ## rls 9 commits in 0d6f53e1a4adbaf7d83cdc0cb54720203fcb522e..6a1b5a9cfda2ae19372e0613e76ebefba36edcf5 2019-02-14 07:52:15 +0000 to 2019-03-04 20:24:45 +0000 - Update cargo and clippy. (rust-lang/rls#1388) - catch up rust-lang/rust PR#58321 (rust-lang/rls#1384) - Apply Clippy fixes (rust-lang/rls#1327) - Various cosmetic improvements (rust-lang/rls#1326) - Make test `RlsHandle` transport-agnostic (rust-lang/rls#1317) - Translate remaining tests (rust-lang/rls#1320) - Remove unnecessary #![feature]s (rust-lang/rls#1323) - Update Clippy (rust-lang/rls#1319) - Update Clippy (rust-lang/rls#1315) cc @Xanewok ## Books See #58936 for details.

HTTPS all the things

0c3851c

rust-highfive assigned nrc Jan 30, 2019

rust-highfive assigned alexcrichton and unassigned nrc Jan 30, 2019

pietroalbini reviewed Jan 30, 2019

View reviewed changes

src/cargo/ops/common_for_install_and_uninstall.rs Outdated Show resolved Hide resolved

Fix the crates ref to point to https://doc.rust-lang.org/cargo

1584bb4

dwijnand reviewed Jan 30, 2019

View reviewed changes

src/cargo/ops/cargo_package.rs Outdated Show resolved Hide resolved

src/cargo/ops/registry.rs Outdated Show resolved Hide resolved

src/bin/cargo/commands/pkgid.rs Outdated Show resolved Hide resolved

Fix ups per dwijnand's review

6d9f3a6

dwijnand reviewed Jan 30, 2019

View reviewed changes

tests/testsuite/build_auth.rs Outdated Show resolved Hide resolved

Fix unit-test error

ee20f73

Try to get build to fix

a9480ed

ehuss reviewed Feb 14, 2019

View reviewed changes

Jonathan Claudius added 2 commits February 22, 2019 14:21

Merge branch 'master' into https_all_the_things

46b2b78

Changes per ehuss

7185e98

bors merged commit 7185e98 into rust-lang:master Feb 27, 2019

ehuss mentioned this pull request Mar 4, 2019

Update cargo, rls, books rust-lang/rust#58920

Merged

ehuss added this to the 1.35.0 milestone Feb 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HTTPS all the things #6614

HTTPS all the things #6614

claudijd commented Jan 30, 2019

rust-highfive commented Jan 30, 2019

pietroalbini commented Jan 30, 2019

alexcrichton commented Jan 30, 2019

bors commented Jan 30, 2019

bors commented Jan 30, 2019

dwijnand left a comment

dwijnand commented Jan 30, 2019

claudijd commented Jan 30, 2019

dwijnand commented Jan 30, 2019

bors commented Jan 30, 2019

bors commented Jan 30, 2019

alexcrichton commented Jan 31, 2019

bors commented Jan 31, 2019

bors commented Jan 31, 2019

dwijnand commented Feb 6, 2019

dwijnand commented Feb 6, 2019

bors commented Feb 6, 2019

bors commented Feb 6, 2019

bors commented Feb 6, 2019

bors commented Feb 12, 2019

ehuss left a comment

ehuss Feb 14, 2019

ehuss Feb 14, 2019

ehuss commented Feb 27, 2019

bors commented Feb 27, 2019

bors commented Feb 27, 2019

bors commented Feb 27, 2019

HTTPS all the things #6614

HTTPS all the things #6614

Conversation

claudijd commented Jan 30, 2019

rust-highfive commented Jan 30, 2019

pietroalbini commented Jan 30, 2019

alexcrichton commented Jan 30, 2019

bors commented Jan 30, 2019

bors commented Jan 30, 2019

dwijnand left a comment

Choose a reason for hiding this comment

dwijnand commented Jan 30, 2019

claudijd commented Jan 30, 2019

dwijnand commented Jan 30, 2019

bors commented Jan 30, 2019

bors commented Jan 30, 2019

alexcrichton commented Jan 31, 2019

bors commented Jan 31, 2019

bors commented Jan 31, 2019

dwijnand commented Feb 6, 2019

dwijnand commented Feb 6, 2019

bors commented Feb 6, 2019

bors commented Feb 6, 2019

bors commented Feb 6, 2019

bors commented Feb 12, 2019

ehuss left a comment

Choose a reason for hiding this comment

ehuss Feb 14, 2019

Choose a reason for hiding this comment

ehuss Feb 14, 2019

Choose a reason for hiding this comment

ehuss commented Feb 27, 2019

bors commented Feb 27, 2019

bors commented Feb 27, 2019

bors commented Feb 27, 2019