Add a way to disable all nightly tests #7142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One thing I'm realizing now is that we test a number of nightly features of Cargo/rustc, but if they change in rustc then because rust-lang/rust's CI run's Cargo's tests it could prevent those changes from landing! The purpose of running Cargo's tests in CI in rust-lang/rust is to ensure that Cargo generally works, but there's no need to test the nightly features as that's Cargo's job. As a result this adds an environment variable that will be set from rust-lang/rust's CI which will disable these tests.
|
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit d78990b has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit d78990b with merge eb4e957936fdea2fe1b978fa87beea642751e4bb... |
|
💔 Test failed - checks-travis |
bors
removed
the
S-waiting-on-bors
|
@bors: retry |
bors
removed
the
S-waiting-on-review
bors
added a commit
that referenced
this pull request
Jul 17, 2019
Add a way to disable all nightly tests One thing I'm realizing now is that we test a number of nightly features of Cargo/rustc, but if they change in rustc then because rust-lang/rust's CI run's Cargo's tests it could prevent those changes from landing! The purpose of running Cargo's tests in CI in rust-lang/rust is to ensure that Cargo generally works, but there's no need to test the nightly features as that's Cargo's job. As a result this adds an environment variable that will be set from rust-lang/rust's CI which will disable these tests.
|
☀️ Test successful - checks-travis, status-appveyor |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jul 26, 2019
Update cargo 11 commits in e3563dbdcd2e370bc4f11d080f739d82d25773fd..d0f828419d6ce6be21a90866964f58eb2c07cd56 2019-07-16 19:22:44 +0000 to 2019-07-23 21:58:59 +0000 - Remove include/exclude glob warning. (rust-lang/cargo#7170) - Optimize lock file format for git merge conflicts (rust-lang/cargo#7070) - Set up CI with Azure Pipelines (rust-lang/cargo#7139) - Force clippy to run. (rust-lang/cargo#7157) - Work around #61440 (rust-lang/cargo#7158) - initial working version of cargo fix --clippy (rust-lang/cargo#7069) - Optimize runtime of `#[cargo_test_macro]` (rust-lang/cargo#7146) - Don't fail if we can't acquire readonly lock (rust-lang/cargo#7149) - Add support for multiple --features options (rust-lang/cargo#7084) - Fix a typo in an env var name (rust-lang/cargo#7145) - Add a way to disable all nightly tests (rust-lang/cargo#7142)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing I'm realizing now is that we test a number of nightly features
of Cargo/rustc, but if they change in rustc then because
rust-lang/rust's CI run's Cargo's tests it could prevent those changes
from landing! The purpose of running Cargo's tests in CI in
rust-lang/rust is to ensure that Cargo generally works, but there's no
need to test the nightly features as that's Cargo's job.
As a result this adds an environment variable that will be set from
rust-lang/rust's CI which will disable these tests.