Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target features reimplemented III #1197 #7203

Closed
wants to merge 21 commits into from
Closed

Target features reimplemented III #1197 #7203

wants to merge 21 commits into from

Conversation

plyhun
Copy link

@plyhun plyhun commented Aug 2, 2019

r? @Eh2406

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 2, 2019
@plyhun
Copy link
Author

plyhun commented Aug 2, 2019

I have added a unit testcase with #7182 (comment) -> No build errors appear on windows during the local test run.

@plyhun plyhun changed the title Target features Target features reimplemented III #1197 Aug 2, 2019
thomwiggers and others added 15 commits August 2, 2019 14:57
@thomwiggers
Add tests for symlinks to git submodules or directories.
ff3d638
@thomwiggers
Check if symlinks are directories
a5fe06a 
Fixes #2748.

Uses @ehuss's suggested fix.
See #6817 (comment)
@thomwiggers
enable the broken_symlink test on Windows
57de13f
@thomwiggers
handle symlinks correctly in support/paths.rs
06bb474
@thomwiggers
Ignore tests that need Administrator privileges on Windows.
74238e5 
This patch allows you to run them when wanted with ``--ignored`` on Windows.
@thomwiggers
Fix doctests that used ignore to hide code that didn't compile.
22f137c
@thomwiggers
Remove appveyor-aimed #[ignore]
2f73513 
Seems like it's no longer necessary (this test ran fine when `--ignored` was specified
@thomwiggers
Don't run symlink tests based on symlink_supported
1ef495f
@thomwiggers
Remove --ignored from CI
3ac678e
@thomwiggers
Cargo fmt
8596fbf
@debris
fix #7007, improve error message for unmatched prerelease dependencies
82adbb6
@alexcrichton
Fix excluding target dirs from backups on OSX
fb79424 
This fixes an accidental regression from #6880 identified in #7189 by
moving where the configuration of backup preferences happens since it
was accidentally never happening due to the folder always having been
created.
@debris
cargo fmt
15fe1e8
@petrochenkov
tests: Enable features to fix unstabilized #[bench]
a4fa868
@alexcrichton
Enable pipelined compilation by default
9cde46c 
This commit enables pipelined compilation by default in Cargo now that
the requisite support has been stablized in rust-lang/rust#62766. This
involved minor updates in a number of locations here and there, but
nothing of meat has changed from the original implementation (just
tweaks to how rustc is called).
@Eh2406
Copy link
Contributor

Eh2406 commented Aug 2, 2019

Sorry, I'm on vacation without access to a computer for the next week and a half.

@plyhun
Copy link
Author

plyhun commented Aug 4, 2019 •
edited
Loading

Again, the merge is broken. What is happening?
Moved to #7209 .

@plyhun plyhun closed this Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Eh2406 Eh2406

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@plyhun @rust-highfive @Eh2406 @snuk182 @thomwiggers @debris @alexcrichton @petrochenkov