Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch build-std to use --extern #7699

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Dec 12, 2019

Switch build-std to use --extern flags instead of --sysroot.

This is mostly a revert of #7421. It uses the new extern flag options introduced in rust-lang/rust#67074. It avoids modifying the extern prelude which was the source of the problem of rust-lang/wg-cargo-std-aware#40.

Closes rust-lang/wg-cargo-std-aware#49
Reopens rust-lang/wg-cargo-std-aware#31

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 12, 2019

📌 Commit 1c779ac has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2019
@bors
Copy link
Contributor

bors commented Dec 12, 2019

⌛ Testing commit 1c779ac with merge 662a965...

bors added a commit that referenced this pull request Dec 12, 2019
Switch build-std to use --extern

Switch `build-std` to use `--extern` flags instead of `--sysroot`.

This is mostly a revert of #7421. It uses the new extern flag options introduced in rust-lang/rust#67074. It avoids modifying the extern prelude which was the source of the problem of rust-lang/wg-cargo-std-aware#40.

Closes rust-lang/wg-cargo-std-aware#49
Reopens rust-lang/wg-cargo-std-aware#31
@bors
Copy link
Contributor

bors commented Dec 12, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 662a965 to master...

@bors bors merged commit 1c779ac into rust-lang:master Dec 12, 2019
@bors bors mentioned this pull request Dec 12, 2019
bors added a commit that referenced this pull request Dec 17, 2019
[beta] Disable test not forwards compatible to nightly.

The `--extern` flag format changed (see #7699).  The changes didn't make it into beta, so just disable this test.  This isn't immediately necessary, but will be helpful if we need to make any other changes on the 1.41 branch in the future.

Closes #7714
@ehuss ehuss added this to the 1.42.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of --sysroot may still be racy and/or allow false dependencies
4 participants