Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependency versions #7809

Closed
wants to merge 1 commit into from
Closed

Conversation

npmccallum
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2020
@alexcrichton
Copy link
Member

Thanks for the PR! Could you elaborate a bit on why this is needed, however? There's no description in the PR and I'm not entirely sure why we would need to do this.

@npmccallum
Copy link
Contributor Author

@alexcrichton I had to edit Cargo.toml for #7811. While doing so, I noticed that there were a bunch of old dependency versions and I figured I'd help do a bit of maintenance for cargo. If this patch is not desirable, feel free to reject it.

@alexcrichton
Copy link
Member

Ok, in that case I don't believe that this is necessary, so I'm going to close this.

@npmccallum npmccallum deleted the update branch January 17, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants