Add note about converting triple case in environment variables #8079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasn't obvious to me, since `CARGO_TARGET_x86_64-unknown-linux-gnu_LINKER` is a perfectly valid environment variable name. It's especially important to document environment variable names well because if you get it wrong it is just silently ignored.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit 9922973 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 9, 2020
Update cargo 4 commits in 6e07d2dfb7fc87b1c9489de41da4dafa239daf03..390e8f245ef2cd7ac698b8a76abf029f9abcab0d 2020-03-31 03:22:39 +0000 to 2020-04-07 17:46:45 +0000 - Compatibility for rust-lang#69926 (rust-lang/cargo#8080) - Add note about converting triple case in environment variables (rust-lang/cargo#8079) - Add support for `-Cembed-bitcode=no` (rust-lang/cargo#8066) - Add triagebot configuration (rust-lang/cargo#8059)
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 9, 2020
Update cargo 4 commits in 6e07d2dfb7fc87b1c9489de41da4dafa239daf03..390e8f245ef2cd7ac698b8a76abf029f9abcab0d 2020-03-31 03:22:39 +0000 to 2020-04-07 17:46:45 +0000 - Compatibility for rust-lang#69926 (rust-lang/cargo#8080) - Add note about converting triple case in environment variables (rust-lang/cargo#8079) - Add support for `-Cembed-bitcode=no` (rust-lang/cargo#8066) - Add triagebot configuration (rust-lang/cargo#8059)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't obvious to me, since
CARGO_TARGET_x86_64-unknown-linux-gnu_LINKERis a perfectly valid environment variable name. It's especially important to document environment variable names well because if you get it wrong it is just silently ignored.