Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to help add an option to Cargo to strip symbols from built binaries. Currently this PR just adds a linker flag, as suggested in this comment.
Questions for reviewers:
I've tried looking at the existing code to add a new
Cargo.toml
option, and I've added this to the[profile.*]
section. Please tell me if it would be better to move it somewhere else.How do we handle this on non-*NIX/non-
ld
platforms? I'm guessing we'll need to detect the configured linker for the respective platform.How do we test this? I could add a test for the config option, but a real test would check that the produced binaries are stripped.
If merged, this closes #3483.