-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta] Do not probe for -Cembed-bitcode
#8206
Conversation
This flag didn't make it to the beta branch of rustc, so remove the probe here in Cargo. This is intended to be a very small patch to remove the probe, since the real support is updated on master and will replace this eventually anyway.
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
📌 Commit 96d5b73 has been approved by |
For some context this was originally added (Apr 3) in #8066 to accompany rust-lang/rust#70458. Unfortuantely the rust-lang/rust PR did not land due to test issues, but it took quite some time for FCP to pass (closed Apr 19). We then renamed the option in #8134 (Apr 19) to accompany a new rustc change at rust-lang/rust#71323 which landed Apr 22. The beta cutoff was Apr 21, however, so although the Cargo changes rode the train into beta none of the rustc changes did. The purpose of this PR is to "back out" the Cargo changes from the beta train. This isn't a straight revert to keep the patch minimal, but the impact of this is that all compilations won't start out with a failed probe to see whether rustc supports Everything should be sorted out on nightly where rustc implements |
☀️ Test successful - checks-azure |
This flag didn't make it to the beta branch of rustc, so remove the
probe here in Cargo. This is intended to be a very small patch to remove
the probe, since the real support is updated on master and will replace
this eventually anyway.