Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Fix clean -p with a build dependency. #8216

Merged
merged 1 commit into from
May 6, 2020

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented May 6, 2020

This is a temporary and simple fix for #8149 where cargo clean -p foo would fail if foo has a build dependency. The full fix is in #8210, but I think that PR is way too risky to backport.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.44.0. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2020
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented May 6, 2020

📌 Commit 5a6849e has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2020
@bors
Copy link
Collaborator

bors commented May 6, 2020

⌛ Testing commit 5a6849e with merge 05d080f...

@bors
Copy link
Collaborator

bors commented May 6, 2020

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 05d080f to rust-1.44.0...

@bors bors merged commit 05d080f into rust-lang:rust-1.44.0 May 6, 2020
@ehuss ehuss added this to the 1.44.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants