Fix order-dependent feature resolution. #8395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ grate find! |
|
📌 Commit ab73b2c has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 24, 2020
Update cargo 9 commits in 089cbb80b73ba242efdcf5430e89f63fa3b5328d..c26576f9adddd254b3dd63aecba176434290a9f6 2020-06-15 14:38:34 +0000 to 2020-06-23 16:21:21 +0000 - Adding environment variable CARGO_PKG_LICENSE_FILE (rust-lang/cargo#8387) - Enable "--target-dir" in "cargo install" (rust-lang/cargo#8391) - Add support for `workspace.metadata` table (rust-lang/cargo#8323) - Fix overzealous `clean -p` for reserved names. (rust-lang/cargo#8398) - Fix order-dependent feature resolution. (rust-lang/cargo#8395) - Correct mispelling of `cargo`. (rust-lang/cargo#8389) - Add missing license field. (rust-lang/cargo#8386) - Adding environment variable CARGO_PKG_LICENSE (rust-lang/cargo#8325) - Cut down on data fetch from git dependencies (rust-lang/cargo#8363)
apoelstra
added a commit
to apoelstra/rust-secp256k1
that referenced
this pull request
Jan 13, 2023
There is a bugfix rust-lang/cargo#8395 which appears in cargo 1.46, after our MSRV of 1.41. This means that under 1.41, users of the rand-std feature may nondeterministically see compilation fail. In particular, users of rust-bitcoin 0.29 seem to have started seeing failures starting on 2023-01-12, where the 'rand-std' feature would be enabled in this library but 'rand' was not. This commit simply makes the 'rand' dependency explicit, to avoid the nondeterministic bug in cargo's feature resolver.
apoelstra
added a commit
to rust-bitcoin/rust-secp256k1
that referenced
this pull request
Jan 13, 2023
66a8c39 backport: fix rand-std feature for old cargo versions (Andrew Poelstra) Pull request description: There is a bugfix rust-lang/cargo#8395 which appears in cargo 1.46, after our MSRV of 1.41. This means that under 1.41, users of the rand-std feature may nondeterministically see compilation fail. In particular, users of rust-bitcoin 0.29 seem to have started seeing failures starting on 2023-01-12, where the 'rand-std' feature would be enabled in this library but 'rand' was not. This commit simply makes the 'rand' dependency explicit, to avoid the nondeterministic bug in cargo's feature resolver. Fixes rust-bitcoin/rust-bitcoin#1546 ACKs for top commit: sanket1729: code review ACK 66a8c39 Tree-SHA512: 896198dd4050bd8f4a71b345e5691ffddf99f6d5a6fdd2e37bf5032359fcb41ee6c8d966de4f90762e93516b2fc654985a8f25edf113d4ced5b06d9a23742e55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a situation where if you have
pkg/featuresyntax, andpkgis an optional dependency, but also a dev-dependency, and the dev-dependency appears before the (optional) normal dependency in the summary, then the optional dependency would not get activated. This is because the feature code usedfindto get the first entry.Fixes #8394