Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space in flag in release notes #8505

Closed
wants to merge 1 commit into from

Conversation

illicitonion
Copy link
Contributor

The = is important as part of the value - 1.2.3 is not an exact version.

The = is important as part of the value - 1.2.3 is not an exact version.
@rust-highfive
Copy link

r? @ehuss

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 18, 2020
@ehuss
Copy link
Contributor

ehuss commented Jul 18, 2020

Hm, I'm a bit confused. The note isn't trying to imply that the = is required. From #8022, the tests like already_installed_exact_does_not_update use that same syntax (install foo --version=1.0.0).

Maybe just remove the = to avoid the amibguity?

@illicitonion
Copy link
Contributor Author

Apologies, you're completely right - I thought that --version took a semver, and forgot that it had special handling for treating 1.2.3 as if it's =1.2.3!

@illicitonion illicitonion deleted the releasenotes branch July 18, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants