Fixed the fossil repo initialization actually run commands #8671
Conversation
set the target directory as ignoreable and cleanable.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ Thanks! |
|
📌 Commit d27170e has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Update cargo 8 commits in 126907a7cfccbe93778530e6a6bbaa3adb6c515c..875e0123259b0b6299903fe4aea0a12ecde9324f 2020-08-31 20:42:11 +0000 to 2020-09-08 20:17:21 +0000 - Lowercase and remove periods in error messages for consistency (rust-lang/cargo#8655) - Allow running build-man.sh from any directory (rust-lang/cargo#8682) - docs: add details for cargo check pass where cargo build fail (rust-lang/cargo#8677) - Fix nightly exported_priv_warning test. (rust-lang/cargo#8678) - fix mdbook test with ```ignore/text/sh/console (rust-lang/cargo#8674) - End CACHEDIR.TAG with newline (rust-lang/cargo#8672) - Fixed the fossil repo initialization actually run commands (rust-lang/cargo#8671) - Remove asciidoc attribute in cargo-metadata man page. (rust-lang/cargo#8670)
I noticed that when using fossil cargo new would not ignore the target directory and that the commands to do so weren't being executed. I wasn't sure if opening an issue was needed as the fix is extremely simple, if an issue is needed I can create one.