Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage doc cargo metadata #8744

Merged
merged 4 commits into from
Oct 2, 2020

Conversation

roblabla
Copy link
Contributor

@roblabla roblabla commented Oct 1, 2020

Adds two new field to cargo-metadata: homepage and documentation, lifted directly from the Cargo.toml. This additionally makes those fields available through cargo read-manifest.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2020
@roblabla roblabla force-pushed the homepage-doc-cargo-metadata branch from 22a15a5 to 26d1a25 Compare October 1, 2020 09:40
@alexcrichton
Copy link
Member

@bors: r+

Seems reasonable to me, thanks!

@bors
Copy link
Contributor

bors commented Oct 2, 2020

📌 Commit 26d1a25 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2020
@bors
Copy link
Contributor

bors commented Oct 2, 2020

⌛ Testing commit 26d1a25 with merge 1f6c6bd...

@bors
Copy link
Contributor

bors commented Oct 2, 2020

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing 1f6c6bd to master...

@bors bors merged commit 1f6c6bd into rust-lang:master Oct 2, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 7, 2020
Update cargo

3 commits in 75615f8e69f748d7ef0df7bc0b064a9b1f5c78b2..9d1a4863abd9237dbf9d1b74c78632b6a205f6bb
2020-09-29 18:42:19 +0000 to 2020-10-05 18:29:52 +0000
- Add LTO to the metadata filename hash. (rust-lang/cargo#8755)
- Fix dylib+rlib with LTO. (rust-lang/cargo#8754)
- Homepage doc cargo metadata (rust-lang/cargo#8744)
@ehuss ehuss added this to the 1.49.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants