Clarify the help text of --aggressive and --precise of update
#9031
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
With the holidays in the US we are not paying as much attention as we normally do. For example the unrelated CI failing are something to do with Nightly, and normally there would be a preity prompt PR fixing it (or turning off Nightly testing) that you could rebase onto. Thank you for your contribution and patients. Otherwize the clarification looks good and is appreciated. |
…ate` This commit makes following 2 changes: - Replace a parameter "<name>" with "SPEC". The former is an older name of the latter before 0d2a243. - Document that both options make sense when used with `-p`, which specifies SPEC.
noritada
force-pushed
the
update-update-descriptions
branch
from
2999e4e
to
1f02563
Compare
|
Thank you very much for fixing the CI failure. I rebased the branch to clarify the PR passing tests in order to reduce the load of your review. |
|
@bors: r+ Thanks! |
|
📌 Commit 1f02563 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Update cargo 12 commits in 75d5d8cffe3464631f82dcd3c470b78dc1dda8bb..329895f5b52a358e5d9ecb26215708b5cb31d906 2020-12-22 18:10:56 +0000 to 2021-01-06 00:01:52 +0000 - metadata: Supply local path for path dependencies (rust-lang/cargo#8994) - Add support for Rust edition 2021. (rust-lang/cargo#8922) - Stabilize -Zfeatures and -Zpackage-features. (rust-lang/cargo#8997) - Small refactor, adding a list of all kinds to BuildContext (rust-lang/cargo#9046) - Fix git http.proxy config setting. (rust-lang/cargo#8986) - Clarify the help text of `--aggressive` and `--precise` of `update` (rust-lang/cargo#9031) - Assert that tests are run in the crate directory (rust-lang/cargo#9037) - Update mdbook (rust-lang/cargo#9044) - Bump to 0.52.0, update changelog (rust-lang/cargo#9042) - Fix redundant semicolon. (rust-lang/cargo#9033) - Clarify fingerprint log messages (rust-lang/cargo#9026) - Update credential docs for gnome-secret. (rust-lang/cargo#9013)
Update cargo 12 commits in 75d5d8cffe3464631f82dcd3c470b78dc1dda8bb..329895f5b52a358e5d9ecb26215708b5cb31d906 2020-12-22 18:10:56 +0000 to 2021-01-06 00:01:52 +0000 - metadata: Supply local path for path dependencies (rust-lang/cargo#8994) - Add support for Rust edition 2021. (rust-lang/cargo#8922) - Stabilize -Zfeatures and -Zpackage-features. (rust-lang/cargo#8997) - Small refactor, adding a list of all kinds to BuildContext (rust-lang/cargo#9046) - Fix git http.proxy config setting. (rust-lang/cargo#8986) - Clarify the help text of `--aggressive` and `--precise` of `update` (rust-lang/cargo#9031) - Assert that tests are run in the crate directory (rust-lang/cargo#9037) - Update mdbook (rust-lang/cargo#9044) - Bump to 0.52.0, update changelog (rust-lang/cargo#9042) - Fix redundant semicolon. (rust-lang/cargo#9033) - Clarify fingerprint log messages (rust-lang/cargo#9026) - Update credential docs for gnome-secret. (rust-lang/cargo#9013)
In the help text,
--aggressiveis described as follows:But
<name>is not documented anywhere and it seems to be an older parameter name ofSPECbefore 0d2a243.This PR updates that parameter name and also clarifies in the help text that
--aggressiveand--precisemake sense when used with-p, which specifiesSPEC.