-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation with serde 1.0.122 #9102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may or may not be a bug in serde, but let's commit a fix here first in any case. Closes rust-lang#9101
r? @Eh2406 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 25, 2021
Thanks! 😄 @bors r+ |
📌 Commit f097d02 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 25, 2021
☀️ Test successful - checks-actions |
Closed
7 tasks
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 28, 2021
Update cargo 7 commits in 783bc43c660bf39c1e562c8c429b32078ad3099b..c3abcfe8a75901c7c701557a728941e8fb19399e 2021-01-20 19:02:26 +0000 to 2021-01-25 16:16:43 +0000 - Minor update to tracking issue template. (rust-lang/cargo#9097) - Add some extra help to `cargo new` and invalid package names. (rust-lang/cargo#9098) - Fix compilation with serde 1.0.122 (rust-lang/cargo#9102) - Add suggestion for bad package id. (rust-lang/cargo#9095) - Remove Registry::new. (rust-lang/cargo#9093) - Fix: set default git config search path for tests (rust-lang/cargo#9035) - Unstable updates (rust-lang/cargo#9092)
Is it worth doing a patch release of the cargo crate on crates.io for this change? |
Eh2406
added a commit
to Eh2406/cargo
that referenced
this pull request
Feb 3, 2021
bors
added a commit
that referenced
this pull request
Feb 3, 2021
Backport #9102 to the 1.50 release branch As per #9124 (comment) here is a backport of #9102
Eh2406
added a commit
to Eh2406/cargo
that referenced
this pull request
Feb 3, 2021
alexcrichton
added a commit
that referenced
this pull request
Feb 3, 2021
Backport #9102 to the 1.49 release branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may or may not be a bug in serde, but let's commit a fix here first
in any case.
Closes #9101