Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ANSI clear-to-EOL if color is force-enabled #9231

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

joshtriplett
Copy link
Member

When running cargo with output not going to a TTY, and with the progress
bar and color force-enabled, this makes cargo clean up its right-aligned
output properly.

This doesn't fix the case where progress is force-enabled and color
isn't, but it fixes the case where both are force-enabled.

When running cargo with output not going to a TTY, and with the progress
bar and color force-enabled, this makes cargo clean up its right-aligned
output properly.

This doesn't fix the case where progress is force-enabled and color
isn't, but it fixes the case where both are force-enabled.
@rust-highfive
Copy link

r? @alexcrichton

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 2, 2021
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 3, 2021

📌 Commit ea46f5c has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2021
@bors
Copy link
Contributor

bors commented Mar 3, 2021

⌛ Testing commit ea46f5c with merge e4aebf0...

@bors
Copy link
Contributor

bors commented Mar 3, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing e4aebf0 to master...

@bors bors merged commit e4aebf0 into rust-lang:master Mar 3, 2021
@joshtriplett joshtriplett deleted the clear-to-eol-if-color branch March 9, 2021 20:04
@ehuss ehuss added this to the 1.52.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants