Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize [env] sections #9411

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Stabilize [env] sections #9411

merged 2 commits into from
Jul 30, 2021

Conversation

joshtriplett
Copy link
Member

[env] sections seem to work as advertised.

@rust-highfive
Copy link

r? @ehuss

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2021
@alexcrichton alexcrichton added the T-cargo Team: Cargo label Apr 26, 2021
@alexcrichton
Copy link
Member

@rfcbot fcp merge

👍

@rfcbot
Copy link
Collaborator

rfcbot commented Apr 26, 2021 •
edited by ehuss
Loading

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period An FCP proposal has started, but not yet signed off. disposition-merge FCP with intent to merge final-comment-period FCP — a period for last comments before action is taken labels Apr 26, 2021
@rfcbot
Copy link
Collaborator

rfcbot commented Apr 26, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period An FCP proposal has started, but not yet signed off. label Apr 26, 2021
ehuss
ehuss reviewed Apr 28, 2021
View reviewed changes
src/doc/src/reference/unstable.md
@@ -1125,32 +1125,6 @@ The `-Z future-incompat-report` flag enables the creation of a future-incompat r
for all dependencies. This makes users aware if any of their crate's dependencies
might stop compiling with a future version of Rust.

### configurable-env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a redirect at the bottom of the page (in the script tag) for the #configurable-env fragment? The target should be "config.html#env"

@rfcbot rfcbot added finished-final-comment-period FCP complete and removed final-comment-period FCP — a period for last comments before action is taken labels May 6, 2021
@rfcbot
Copy link
Collaborator

rfcbot commented May 6, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@ehuss
Copy link
Contributor

ehuss commented May 20, 2021

Ping @joshtriplett, not sure if you're still interested in pushing this. If you want to fix the small nit about the redirect, I don't think there are any other blockers.

@bors
Copy link
Contributor

bors commented May 24, 2021

☔ The latest upstream changes (presumably #9473) made this pull request unmergeable. Please resolve the merge conflicts.

@ehuss ehuss added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2021
@joshtriplett joshtriplett added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Jul 30, 2021
@joshtriplett
Copy link
Member Author

(Currently fixing the merge conflicts)

@joshtriplett joshtriplett force-pushed the stabilize-configurable-env branch from fa5bbd4 to 323265d Compare July 30, 2021 02:55
@joshtriplett joshtriplett added the relnotes Release-note worthy label Jul 30, 2021
@joshtriplett
Copy link
Member Author

I believe this is now ready to merge, and has passed FCP.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 30, 2021

📌 Commit 323265d has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2021
@bors
Copy link
Contributor

bors commented Jul 30, 2021

⌛ Testing commit 323265d with merge 9225ac7...

@bors
Copy link
Contributor

bors commented Jul 30, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing 9225ac7 to master...

@bors bors merged commit 9225ac7 into rust-lang:master Jul 30, 2021
@joshtriplett joshtriplett deleted the stabilize-configurable-env branch August 3, 2021 09:52
@ehuss ehuss mentioned this pull request Aug 3, 2021
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 3, 2021
@JohnTitor
Rollup merge of rust-lang#87731 - ehuss:update-cargo, r=ehuss
9f0eba9 
Update cargo

11 commits in d21c22870e58499d6c31f1bef3bf1255eb021666..cc17afbb0067b1f57d8882640f63b2168d5b7624
2021-07-26 20:23:21 +0000 to 2021-08-02 20:28:08 +0000
- Stabilize the rust-version field (rust-lang/cargo#9732)
- Remove nbsp characters. (rust-lang/cargo#9751)
- Update unstable documentation TOC. (rust-lang/cargo#9750)
- Some minor updates for package/publish package selection. (rust-lang/cargo#9749)
- Bump to 0.57.0, update changelog (rust-lang/cargo#9748)
- Stabilize `[env]` sections (rust-lang/cargo#9411)
- doc: Clarify [doc].browser docs, document PathAndArgs better (rust-lang/cargo#9747)
- Bump cargo-util version. (rust-lang/cargo#9745)
- Make clippy happy (rust-lang/cargo#9736)
- Fix typo in features doc (rust-lang/cargo#9737)
- doc test supports silent output (rust-lang/cargo#9730)
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 3, 2021
@JohnTitor
Rollup merge of rust-lang#87731 - ehuss:update-cargo, r=ehuss
1666c26 
Update cargo

11 commits in d21c22870e58499d6c31f1bef3bf1255eb021666..cc17afbb0067b1f57d8882640f63b2168d5b7624
2021-07-26 20:23:21 +0000 to 2021-08-02 20:28:08 +0000
- Stabilize the rust-version field (rust-lang/cargo#9732)
- Remove nbsp characters. (rust-lang/cargo#9751)
- Update unstable documentation TOC. (rust-lang/cargo#9750)
- Some minor updates for package/publish package selection. (rust-lang/cargo#9749)
- Bump to 0.57.0, update changelog (rust-lang/cargo#9748)
- Stabilize `[env]` sections (rust-lang/cargo#9411)
- doc: Clarify [doc].browser docs, document PathAndArgs better (rust-lang/cargo#9747)
- Bump cargo-util version. (rust-lang/cargo#9745)
- Make clippy happy (rust-lang/cargo#9736)
- Fix typo in features doc (rust-lang/cargo#9737)
- doc test supports silent output (rust-lang/cargo#9730)
@ehuss ehuss mentioned this pull request Jan 17, 2022
Closed
1 task
@ehuss ehuss added this to the 1.56.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss left review comments

Assignees

@ehuss ehuss

Labels
disposition-merge FCP with intent to merge finished-final-comment-period FCP complete relnotes Release-note worthy S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-cargo Team: Cargo to-announce
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.
6 participants
@joshtriplett @rust-highfive @alexcrichton @rfcbot @ehuss @bors