Always use full metadata hash for -C metadata. #9418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes it so that cargo always uses the full metadata hash for
-C metadata
. This ensures that even if a unit isn't using-C extra-filename
that the symbol hashing uses all the fields used in the other cases.This fixes an issue on macOS where a combination of split-debuginfo and incremental caused the same
.o
filenames to be used, which caused corruption in the incremental cache (see issue for details).Fixes #9353.