Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude target from content-indexing on Windows #9635

Merged
merged 4 commits into from
Jun 30, 2021
Merged

Exclude target from content-indexing on Windows #9635

merged 4 commits into from
Jun 30, 2021

Conversation

toothbrush7777777
Copy link
Contributor

This has a noticeable performance improvement for most projects, especially when the storage device is a hard drive.

Closes #8694

This has a noticeable performance improvement for most projects, especially when the storage device is a hard drive.

Closes #8694
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2021
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, thanks for this! I think there may be some build errors in CI for other platforms, but otherwise this looks good to me to merge.

crates/cargo-util/src/paths.rs Outdated Show resolved Hide resolved
This fixes builds on non-Windows platforms.
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 30, 2021

📌 Commit c973a6d has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2021
@bors
Copy link
Contributor

bors commented Jun 30, 2021

⌛ Testing commit c973a6d with merge 5dfdec06e70c314301b1da46586d8df44c856191...

@bors
Copy link
Contributor

bors commented Jun 30, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 30, 2021
@alexcrichton
Copy link
Member

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2021
@bors
Copy link
Contributor

bors commented Jun 30, 2021

⌛ Testing commit c973a6d with merge 01d059a...

@bors
Copy link
Contributor

bors commented Jun 30, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing 01d059a to master...

@bors bors merged commit 01d059a into rust-lang:master Jun 30, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2021
Update cargo

9 commits in 9233aa06c801801cff75df65df718d70905a235e..4952979031e2cf1d901c817a32e25a156a19db4c
2021-06-22 21:32:55 +0000 to 2021-07-01 01:14:50 +0000
- Fix `BorrowMutError` when calling `cargo doc --open` (rust-lang/cargo#9531)
- Exclude `target` from content-indexing on Windows (rust-lang/cargo#9635)
- Temporarily ignore 2021 edition fix. (rust-lang/cargo#9642)
- Temporarily disable future_incompat tests. (rust-lang/cargo#9638)
- Include toolchain specification in error message (rust-lang/cargo#9625)
- Error when packaging with git dependencies without version (rust-lang/cargo#9612)
- simply 'if' block (rust-lang/cargo#9615)
- tidy some closures and iterators (rust-lang/cargo#9614)
- use 'writeln' instead of appending newline character (rust-lang/cargo#9620)
@toothbrush7777777 toothbrush7777777 deleted the patch-1 branch July 5, 2021 15:27
@ehuss ehuss added this to the 1.55.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchIndexer takes time indexing \target on windows
6 participants