-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude target
from content-indexing on Windows
#9635
Conversation
This has a noticeable performance improvement for most projects, especially when the storage device is a hard drive. Closes #8694
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me, thanks for this! I think there may be some build errors in CI for other platforms, but otherwise this looks good to me to merge.
This fixes builds on non-Windows platforms.
@bors: r+ |
📌 Commit c973a6d has been approved by |
⌛ Testing commit c973a6d with merge 5dfdec06e70c314301b1da46586d8df44c856191... |
💔 Test failed - checks-actions |
@bors: retry |
☀️ Test successful - checks-actions |
Update cargo 9 commits in 9233aa06c801801cff75df65df718d70905a235e..4952979031e2cf1d901c817a32e25a156a19db4c 2021-06-22 21:32:55 +0000 to 2021-07-01 01:14:50 +0000 - Fix `BorrowMutError` when calling `cargo doc --open` (rust-lang/cargo#9531) - Exclude `target` from content-indexing on Windows (rust-lang/cargo#9635) - Temporarily ignore 2021 edition fix. (rust-lang/cargo#9642) - Temporarily disable future_incompat tests. (rust-lang/cargo#9638) - Include toolchain specification in error message (rust-lang/cargo#9625) - Error when packaging with git dependencies without version (rust-lang/cargo#9612) - simply 'if' block (rust-lang/cargo#9615) - tidy some closures and iterators (rust-lang/cargo#9614) - use 'writeln' instead of appending newline character (rust-lang/cargo#9620)
This has a noticeable performance improvement for most projects, especially when the storage device is a hard drive.
Closes #8694