Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better msg for wrong position #9723

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

Rustin170506
Copy link
Member

close #9717

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@rust-highfive
Copy link

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2021
@ehuss
Copy link
Contributor

ehuss commented Jul 24, 2021

I think the original was correct. Bracketed headers are called "tables" in TOML.

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506
Copy link
Member Author

I think the original was correct. Bracketed headers are called "tables" in TOML.

Addressed.

@Rustin170506
Copy link
Member Author

Thanks for your review!

@ehuss
Copy link
Contributor

ehuss commented Jul 26, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Jul 26, 2021

📌 Commit 5ccb5a3 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2021
@bors
Copy link
Contributor

bors commented Jul 26, 2021

⌛ Testing commit 5ccb5a3 with merge d403db6...

@bors
Copy link
Contributor

bors commented Jul 26, 2021

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing d403db6 to master...

@bors bors merged commit d403db6 into rust-lang:master Jul 26, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 27, 2021
Update cargo

8 commits in cebef2951ee69617852844894164b54ed478a7da..d21c22870e58499d6c31f1bef3bf1255eb021666
2021-07-22 13:01:52 +0000 to 2021-07-26 20:23:21 +0000
- Fix version string. (rust-lang/cargo#9727)
- Allow publishing from workspace root. (rust-lang/cargo#9559)
- Better msg for wrong position (rust-lang/cargo#9723)
- Stabilize the rustc-link-arg option (rust-lang/cargo#9557)
- Warning when using features in replace (rust-lang/cargo#9681)
- Refactor if let chains to matches! macro (rust-lang/cargo#9721)
- Weather is not nice today.. (rust-lang/cargo#9720)
- Update should_use_metadata function (rust-lang/cargo#9653)
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 27, 2021
Update cargo

8 commits in cebef2951ee69617852844894164b54ed478a7da..d21c22870e58499d6c31f1bef3bf1255eb021666
2021-07-22 13:01:52 +0000 to 2021-07-26 20:23:21 +0000
- Fix version string. (rust-lang/cargo#9727)
- Allow publishing from workspace root. (rust-lang/cargo#9559)
- Better msg for wrong position (rust-lang/cargo#9723)
- Stabilize the rustc-link-arg option (rust-lang/cargo#9557)
- Warning when using features in replace (rust-lang/cargo#9681)
- Refactor if let chains to matches! macro (rust-lang/cargo#9721)
- Weather is not nice today.. (rust-lang/cargo#9720)
- Update should_use_metadata function (rust-lang/cargo#9653)
@ehuss ehuss added this to the 1.56.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo dignostic for misplaced cargo-features = ["edition2021"] could be better
5 participants