Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove log output that may leak tokens #9873

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Remove log output that may leak tokens #9873

merged 2 commits into from
Sep 8, 2021

Conversation

Rustin170506
Copy link
Member

close #9822

@Rustin170506
Mask token with "*"
edad75d 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@rust-highfive
Copy link

r? @ehuss

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2021
ehuss
ehuss reviewed Sep 7, 2021
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think it would be fine just to remove the log entirely. I don't remember exactly why I added that, but I think it was just for debugging the initial implementation, and I don't think it is too important to keep it around.

@Rustin170506 Rustin170506 requested a review from ehuss September 8, 2021 12:51
@Rustin170506 Rustin170506 changed the title Mask token with "*" Remove log output that may leak tokens Sep 8, 2021
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 8, 2021

📌 Commit e387939 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2021
@bors
Copy link
Contributor

bors commented Sep 8, 2021

⌛ Testing commit e387939 with merge e515c32...

@bors
Copy link
Contributor

bors commented Sep 8, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing e515c32 to master...

@bors bors merged commit e515c32 into rust-lang:master Sep 8, 2021
@Rustin170506 Rustin170506 deleted the rustin-patch-mask branch September 8, 2021 15:01
@ehuss ehuss mentioned this pull request Sep 8, 2021
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 12, 2021
@Manishearth
Rollup merge of rust-lang#88766 - ehuss:update-cargo, r=ehuss
11a4efc 
Update cargo

6 commits in 18751dd3f238d94d384a7fe967abfac06cbfe0b9..e515c3277bf0681bfc79a9e763861bfe26bb05db
2021-09-01 14:26:00 +0000 to 2021-09-08 14:32:15 +0000
- Remove log output that may leak tokens (rust-lang/cargo#9873)
- rev = "refs/pull/𑑛/head" (rust-lang/cargo#9859)
- Update suggestion message on bad project name error (rust-lang/cargo#9877)
- clarify what goes into "*-sys" crates (rust-lang/cargo#9871)
- Improve error message when unable to initialize git index repo (rust-lang/cargo#9869)
- Use serde_json to generate cargo_vcs_info.json (rust-lang/cargo#9865)
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 13, 2021
@bors
Auto merge of rust-lang#88766 - ehuss:update-cargo, r=ehuss
b0ee495 
Update cargo

6 commits in 18751dd3f238d94d384a7fe967abfac06cbfe0b9..e515c3277bf0681bfc79a9e763861bfe26bb05db
2021-09-01 14:26:00 +0000 to 2021-09-08 14:32:15 +0000
- Remove log output that may leak tokens (rust-lang/cargo#9873)
- rev = "refs/pull/𑑛/head" (rust-lang/cargo#9859)
- Update suggestion message on bad project name error (rust-lang/cargo#9877)
- clarify what goes into "*-sys" crates (rust-lang/cargo#9871)
- Improve error message when unable to initialize git index repo (rust-lang/cargo#9869)
- Use serde_json to generate cargo_vcs_info.json (rust-lang/cargo#9865)
@ehuss ehuss added this to the 1.57.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss Awaiting requested review from ehuss

Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.

Registry token shown in debug logs
5 participants
@Rustin170506 @rust-highfive @alexcrichton @bors @ehuss