Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "wrong output" error. #9905

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Sep 11, 2021

The error message for an improperly formatted build script output was a bit abrupt and unhelpful. This adds some more details to the error message.

@rust-highfive
Copy link

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2021
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Sep 13, 2021

📌 Commit c4e92ac has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2021
@bors
Copy link
Collaborator

bors commented Sep 13, 2021

⌛ Testing commit c4e92ac with merge 2387effbf4169e84319cc1fb08243704be7924d1...

@bors
Copy link
Collaborator

bors commented Sep 13, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 13, 2021
@camelid
Copy link
Member

camelid commented Sep 13, 2021

This can probably be retried now, since #9906 has been merged.

@alexcrichton
Copy link
Member

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2021
@ehuss
Copy link
Contributor Author

ehuss commented Sep 13, 2021

@bors retry

@bors
Copy link
Collaborator

bors commented Sep 13, 2021

⌛ Testing commit c4e92ac with merge 16eb1dfaa6398af9c3a9645fbe7e4b314b0a3337...

@bors
Copy link
Collaborator

bors commented Sep 13, 2021

⌛ Testing commit c4e92ac with merge f7ca659...

@bors
Copy link
Collaborator

bors commented Sep 13, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing f7ca659 to master...

@bors bors merged commit f7ca659 into rust-lang:master Sep 13, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 17, 2021
Update cargo

13 commits in e515c3277bf0681bfc79a9e763861bfe26bb05db..33ee5f82edb50af87b952c5b28de0f5fb41ebf18
2021-09-08 14:32:15 +0000 to 2021-09-17 13:51:54 +0000
- Update curl-sys (rust-lang/cargo#9917)
- Bump Cargo's curl requirement to 7.79.0 (rust-lang/cargo#9914)
- Revert "When a dependency does not have a version, git or path, fails directly" (rust-lang/cargo#9911)
- Add some contributor docs for debugging testsuite tests. (rust-lang/cargo#9904)
- Fix warnings when documenting with `--document-private-items` (rust-lang/cargo#9903)
- Improve "wrong output" error. (rust-lang/cargo#9905)
- Fix warnings from better precision of `dead_code` lint (rust-lang/cargo#9906)
- Bump to 0.58.0, update changelog (rust-lang/cargo#9900)
- Fix rustc --profile=dev unstable check. (rust-lang/cargo#9898)
- config.md: fix typo (rust-lang/cargo#9896)
- Enable some tests on windows. (rust-lang/cargo#9893)
- Enable strip test on macos. (rust-lang/cargo#9889)
- Fix `cargo fix --edition` on stable. (rust-lang/cargo#9890)
@ehuss ehuss added this to the 1.57.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants