-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some more information to verbose version. #9968
Conversation
r? @Eh2406 (rust-highfive has picked a reviewer for you, use r? to override) |
This doesn't include everything mentioned in #6275 and #6161. Things not included:
I'm not saying the above information isn't useful, I just don't want to spend a lot of time on this. The only thing missing that I really want is the OS version. However, that is extremely difficult to get reliably. I found https://crates.io/crates/os_info which actually looks to be pretty thorough and well written for the few platforms that I looked at. However, I don't know if that covers every platform we build for, and I fear it will make life difficult for people porting cargo to other platforms. Thoughts? |
For OS version information are you thinking of learning about things like the macOS patch number or things like that? I find it doesn't come up too too often but I agree that if it's easy-ish to put in here then we may as well because it can often be a red flag if something is super old or extremely new. I'm not too worried about the platform compatibility in that if we know about it ahead of time we can have it be opt-in for platforms instead of opt-out. For example we could probably turn it on for macOS and Windows by default and then allow-list platforms like Linux and such as they are implemented. If something is missing from a platform's Otherwise though this looks great to me and r=me when you feel like this is ready. |
Thank you for moving this forward! I have had cases where resolver bugs did not reproduce that we thought where do to index changes. But now I cant find a link to an example. So it can't be that common.
Anyway +1 from me when you are happy! |
OK, I went ahead and added @bors r=alexcrichton,Eh2406 |
📌 Commit 9f5da7c has been approved by |
☀️ Test successful - checks-actions |
Update cargo 7 commits in d56b42c549dbb7e7d0f712c51b39400260d114d4..c7957a74bdcf3b11e7154c1a9401735f23ebd484 2021-09-27 13:44:18 +0000 to 2021-10-11 20:17:07 +0000 - Add some more information to verbose version. (rust-lang/cargo#9968) - Skip all `cargo fix` that tends to write to registry cache. (rust-lang/cargo#9938) - Stabilize named profiles (rust-lang/cargo#9943) - Update git2 (rust-lang/cargo#9963) - Distinguish lockfile version req from normal dep in resolver error message (rust-lang/cargo#9847) - nit: Allocated slightly bigger vec than needed (rust-lang/cargo#9954) - Add shell completion for shorthand commands (rust-lang/cargo#9951)
This adds a little bit of extra information to the verbose version command.
cc #6275 and #6161
Some examples of what it might look like: