Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.91 update breaks cargo-xwin #1026

Closed
namse opened this issue Apr 8, 2024 · 6 comments · Fixed by #1027
Closed

1.0.91 update breaks cargo-xwin #1026

namse opened this issue Apr 8, 2024 · 6 comments · Fixed by #1027

Comments

@namse
Copy link

namse commented Apr 8, 2024

related issue: rust-cross/cargo-xwin#104

minimal reproducible example: https://github.com/namse/cc-rs-1.0.91-issue

Would you please check this problem?
@NobodyXu
Copy link
Collaborator

NobodyXu commented Apr 8, 2024

I think this is related to #1015 cc @russelltg

NobodyXu added a commit that referenced this issue Apr 8, 2024
@NobodyXu
Fix linking with llvm-lib
a03257a 
Fix #1026
@NobodyXu NobodyXu mentioned this issue Apr 8, 2024
Merged
@NobodyXu
Copy link
Collaborator

NobodyXu commented Apr 8, 2024

@namse I've opened #1027 , can you please try it out?

@NobodyXu NobodyXu mentioned this issue Apr 8, 2024
Open
7 tasks
@namse
Copy link
Author

namse commented Apr 8, 2024

@NobodyXu Works very well I guess?
image

@namse
Copy link
Author

namse commented Apr 8, 2024 •
edited
Loading

1.0.91 fails build on mimalloc crate
image

but on cc = { git = "https://github.com/rust-lang/cc-rs.git", rev = "a03257af4a578cd2b7842b6109a6d817035d7a38" }, it build well (previous screenshot #1026 (comment)), the commit of #1027.

1.0.90 also good.

NobodyXu added a commit that referenced this issue Apr 8, 2024
@NobodyXu
Fix linking with llvm-lib (#1027)
e73d05b 
Fix #1026
@namse
Copy link
Author

namse commented Apr 8, 2024

Would you make a 1.0.92 tag to release to crate.io?

@NobodyXu
Copy link
Collaborator

NobodyXu commented Apr 8, 2024

Thanks, I've published the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix linking with llvm-lib rust-lang/cc-rs
2 participants
@namse @NobodyXu