Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target strings that end in -none (such as aarch64-unknown-none) should not default to -fPIC #1211

Closed
schultetwin1 opened this issue Sep 17, 2024 · 0 comments · Fixed by #1212
Closed

Target strings that end in -none (such as aarch64-unknown-none) should not default to -fPIC #1211

schultetwin1 opened this issue Sep 17, 2024 · 0 comments · Fixed by #1212

Comments

@schultetwin1
Copy link
Contributor

According to the docs

This [pic] option defaults to false for windows-gnu and bare metal targets and to true for all other targets.

This means the bare metal target aarch64-unknown-none should default to false, but the current logic only looks for -none-, and not -none.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

disable pic for targets that end in -none schultetwin1/cc-rs
1 participant
@schultetwin1