Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in 1.1.32 in cc::windows_registry::find_tool #1281

Closed
slonopotamus opened this issue Nov 8, 2024 · 2 comments
Closed

Regression in 1.1.32 in cc::windows_registry::find_tool #1281

slonopotamus opened this issue Nov 8, 2024 · 2 comments

Comments

@slonopotamus
Copy link

slonopotamus commented Nov 8, 2024

Way to reproduce

  1. Windows
  2. Installed Visual Studio 2022 with C++ workload
  3. Attempt to find path to compiler executable using let tool = cc::windows_registry::find_tool("x86_64-msvc", "cl.exe").unwrap();

cc-1.1.31 and older work.
cc-1.1.32 and newer panic because find_tool returns None.

Can both repro on my own machine and on GitHub Actions.

Maybe I am using find_tool the wrong way and need to pass different arguments?

slonopotamus added a commit to octobuild/octobuild that referenced this issue Nov 8, 2024
@NobodyXu
Copy link
Collaborator

NobodyXu commented Nov 8, 2024

x86_64-msvc is not a valid rust target.

I'd recommend changing it to x86_64-pc-windows-msvc

@slonopotamus
Copy link
Author

Thanks, using x86_64-pc-windows-msvc fixed things for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants