Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile family detection: Use C macros instead of $compiler -v #1000

Merged
merged 15 commits into from
Mar 17, 2024
Merged

Fix compile family detection: Use C macros instead of $compiler -v #1000

merged 15 commits into from
Mar 17, 2024

Conversation

NobodyXu
Copy link
Collaborator

@NobodyXu NobodyXu commented Mar 7, 2024

Fixed #958

NobodyXu added 10 commits March 8, 2024 01:02
@NobodyXu
Impl NamedTempfile
a7e0c6a 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Detect compiler family by using C macros
8a2efd7 
which is more robust than checking output of `$compiler -v`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Add detect_compiler_family.c
d214af4 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix gnu_flag_if_supported and gnu_flag_if_supported_cpp
779bed4 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Disable warning for compiler family detection
681a1f9 
When expanding the file, the compiler prints a lot of information to stderr
that it is not an error, but related to expanding itself.

cc would have to disable warning here to prevent generation of too many warnings.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Enable stderr forwarding for compiler family detection if debugging o…
093848c 
…utput is enabled

It's good to have the output for debugging.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Print stdout from compiler family detection if debugging output is en…
aa2b4b6 
…abled

Can help find issues related to compiler family detection.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Enable debugging output for CI
1d8cf41 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix flag_if_supported failure due to OUT_DIR not set
ea72216 
Fallback to create `NamedTempfile` in `std::env::temp_dir()`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix test on cargo warnings
f70eafa 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu marked this pull request as ready for review March 8, 2024 07:51
@NobodyXu
Revert changes to src/bin/gcc-shim.rs
ada78b9 
It's not necessary.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu mentioned this pull request Mar 8, 2024
Closed
@NobodyXu
Remove unnecessary .stderr(Stdio::null()) in tool.rs
f3b5946 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu mentioned this pull request Mar 8, 2024
Closed
Be-ing
Be-ing reviewed Mar 9, 2024
View reviewed changes
src/tool.rs Show resolved Hide resolved
@messense messense mentioned this pull request Mar 13, 2024
Closed
@workingjubilee workingjubilee mentioned this pull request Mar 14, 2024
Open
@NobodyXu NobodyXu mentioned this pull request Mar 15, 2024
Merged
NobodyXu added 2 commits March 15, 2024 21:56
@NobodyXu
Merge branch 'main' into fix/compile-family-detection
805f9b4
@NobodyXu
Run cargo fmt
1ab8a9d 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
workingjubilee
workingjubilee reviewed Mar 16, 2024
View reviewed changes
src/tempfile.rs Outdated Show resolved Hide resolved
This was referenced Mar 16, 2024
Open
Closed
@NobodyXu
Add comment to disable_debug_output in cc-test/build.rs
467bd8c 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu requested a review from workingjubilee March 17, 2024 00:46
@NobodyXu NobodyXu mentioned this pull request Mar 17, 2024
Open
workingjubilee
workingjubilee approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work locally. Can't attest to Windows correctness, but we'll find out very quickly if it isn't.

@NobodyXu NobodyXu merged commit f36d6a7 into main Mar 17, 2024
42 checks passed
@NobodyXu NobodyXu deleted the fix/compile-family-detection branch March 17, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing left review comments

@workingjubilee workingjubilee workingjubilee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler version doesn't include clang or GCC: "cc" "--version"
3 participants
@NobodyXu @Be-ing @workingjubilee