Support CROSS_COMPILE environment variable #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used as last resort when HOST != TARGET.
|
Intended as one approach to #82. This is kinda ugly, because I had to juggle an No tests or docs because I'm spitballing an approach for now. 😳 |
|
Thanks! I wonder if perhaps this should be prioritized over the fallback prefixes though? It seems like it this variable is set it's higher priority |
|
Hmm, yeah. 😳 This is a bit ooky, but it looks better than |
|
Thanks! |
|
Oh! That is a surprise. I hadn't written docs, tests, or extended it to the other tools yet. I'll follow up in a separate PR. 😀 |
|
Oh ok seems fine to me :) |
ruuda
added a commit
to ruuda/filebuffer
that referenced
this pull request
Oct 22, 2016
The gcc crate, a transitive dependency of rust-crypto, recently released a new version that breaks compatibility with Rust 1.4 through 1.6. Because no major version bump was done, Cargo will prefer the more recent version when no Cargo.lock is present. This is the case on CI, so the builds are failing for Rust 1.4 through 1.6, even though they would build fine with an older gcc crate. To work around this, add an explicit dependency on gcc, locked to the non-broken version. Because gcc is only a dependency of rust-crypto which is a dev-dependency, gcc can be added as a dev-dependency too, so this will not affect crates that depend on Filebuffer, fortunately. For reference, the reason gcc is broken is because code was introduced in [1] (commit 5f97af47013607521b70cb254a1b581cde2310a0) that uses the function String::as_str, which was only stabilized in Rust 1.7.0. [1]: rust-lang/cc-rs#106
ruuda
added a commit
to ruuda/filebuffer
that referenced
this pull request
Oct 22, 2016
The gcc crate, a transitive dependency of rust-crypto, recently released a new version that breaks compatibility with Rust 1.4 through 1.6. Because no major version bump was done, Cargo will prefer the more recent version when no Cargo.lock is present. This is the case on CI, so the builds are failing for Rust 1.4 through 1.6, even though they would build fine with an older gcc crate. To work around this, add an explicit dependency on gcc, locked to the non-broken version. Because gcc is only a dependency of rust-crypto which is a dev-dependency, gcc can be added as a dev-dependency too, so this will not affect crates that depend on Filebuffer, fortunately. For reference, the reason gcc is broken is because code was introduced in [1] (commit 5f97af47013607521b70cb254a1b581cde2310a0) that uses the function String::as_str, which was only stabilized in Rust 1.7.0. [1]: rust-lang/cc-rs#106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used as last resort when HOST != TARGET.