Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accpet OsStr instead of str for flags #1100

Merged
merged 9 commits into from
Jun 23, 2024
Merged

Accpet OsStr instead of str for flags #1100

merged 9 commits into from
Jun 23, 2024

Commits on Jun 22, 2024

  1. Update getenv to return Arc<Ostr> instead of Arc<str> 

    It is possible that the environment variable contains non-utf8 charactes

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    cced1bb View commit details
    Browse the repository at this point in the history

  2. Update get_cpp_link_stdlib to return `Result<Option<Cow<'_, Path>>,… 

    … Error>`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    4acbec4 View commit details
    Browse the repository at this point in the history

  3. Update cpp_{set, link}_stdlib to accept Path instead of str 

    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    55507fc View commit details
    Browse the repository at this point in the history

  4. Optimize prefix_for_target to ret Cow<'static, str> 

    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    2620349 View commit details
    Browse the repository at this point in the history

  5. Accept impl AsRef<OsStr> for asm, ar and cc/cxx flags and `link_lib… 

    …_modifiers`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    a143668 View commit details
    Browse the repository at this point in the history

  6. Improve debug logging in getenv 

    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    b452901 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. Revert deprecation

    @NobodyXu
    NobodyXu authored Jun 23, 2024
    Configuration menu
    Copy the full SHA
    355924b View commit details
    Browse the repository at this point in the history

  2. Revert cpp_{set, link}_stdlib changes 

    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    fe98c2c View commit details
    Browse the repository at this point in the history

  3. Fix doc 

    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    40397fd View commit details
    Browse the repository at this point in the history