Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIX] use -maix64 instead of -m64 #1307

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[AIX] use -maix64 instead of -m64 #1307

merged 1 commit into from
Dec 12, 2024

Conversation

mustartt
Copy link
Contributor

@mustartt mustartt commented Nov 29, 2024 •
edited
Loading

On AIX, gcc -m64 is not a valid flag. We use the corresponding -maix64 for GCC and the regular -m64 for Clang.

@mustartt mustartt marked this pull request as ready for review December 2, 2024 17:23
NobodyXu
NobodyXu approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM, I have read through the code before but forgot to approve and merge it

@NobodyXu NobodyXu merged commit 9185b6a into rust-lang:main Dec 12, 2024
27 checks passed
@github-actions github-actions bot mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mustartt @NobodyXu