Detect and use IPHONEOS_DEPLOYMENT_TARGET for the -mi*os-version-min flag
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in` flag If it isn't set, fallback to the previous setting of `-miphoneos-version-min=7.0` for real devices and `mios-simulator-version-min=7.0` for simulators.
|
This is at least a good start, thanks @turboladen! |
|
And thank you, @alexcrichton, for all the goodies you put out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...If it isn't set, fallback to the previous setting of
-miphoneos-version-min=7.0for real devices andmios-simulator-version-min=7.0for simulators.I realize this doesn't quite fulfill the request in #383 (defining a method on
Tool), but it at least allows you to specify your targeted minimum version in what seems to be a conventional way (I'm not super familiar with building Xcode projects from the CLI). In my case, I'm usingcmake-rsto build a C project, which uses cmake to build an iOS project, all for my Rust project, and this change allowed me to get that project building.I'd really like to implement that method on
Tool, but after a few days now I realize I won't have the time in the near future and don't want to let my changes go stale. I hope this is helpful...